From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1Xu0PR-0003YH-HF
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:51:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1Xu0PL-0004lL-CF
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:51:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1Xu0PK-0004kp-Oc
	for qemu-devel@nongnu.org; Thu, 27 Nov 2014 09:50:58 -0500
Message-ID: <1417099796.2807.41.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Thu, 27 Nov 2014 16:49:56 +0200
In-Reply-To: <CAFEAcA954hhRVhiWzUQ6OYi=kCbRHmAJPx_Cdj-6LyQ1hwQXXw@mail.gmail.com>
References: <1417002601-20799-1-git-send-email-marcel.a@redhat.com>
	<20141126130528.50835019@redhat.com>
	<1417086688.2807.19.camel@localhost.localdomain>
	<1417088141.4177.2.camel@G08FNSTD140041>
	<1417088467.2807.29.camel@localhost.localdomain>
	<CAFEAcA954hhRVhiWzUQ6OYi=kCbRHmAJPx_Cdj-6LyQ1hwQXXw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hmp: fix regression of HMP device_del
 auto-completion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mammedov <imammedo@redhat.com>, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, QEMU Developers <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, 2014-11-27 at 14:13 +0000, Peter Maydell wrote:
> On 27 November 2014 at 11:41, Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> > I was talking about something different:
> > A hot-pluggable device that was not hot-plugged is assumed to be hot-unpluggable.
> > This is not true for pci-2-pci device.
> >
> > But this is another issue and can wait for 2.3.
> > So you patch was *almost* correct for looking hotpluggable devices,
> > the only problem we have is with pci-2-pci bridge (, and maybe with others that I don't know).
> 
> So, to be clear, the effect of this is just that our autocompletion
> will suggest a completion to the command which will fail if actually
> executed, right? That doesn't sound very serious, so I would be happy
> to postpone it to 2.3.
Correct. But only if this patch is applied, before this patch is a QEMU
crash.

Please pull it to solve the crash and we will deal with the other issues on 2.3

Thanks,
Marcel
> 
> -- PMM