From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbaK1Lye (ORCPT ); Fri, 28 Nov 2014 06:54:34 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:10886 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbaK1Lyb (ORCPT ); Fri, 28 Nov 2014 06:54:31 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f5-b7fc86d0000066b7-82-54786274547c Content-transfer-encoding: 8BIT Message-id: <1417175667.18249.26.camel@AMDC1943> Subject: Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property From: Krzysztof Kozlowski To: Mark Brown Cc: Lee Jones , Liam Girdwood , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Date: Fri, 28 Nov 2014 12:54:27 +0100 In-reply-to: <20141128112116.GG7712@sirena.org.uk> References: <1417087253-12306-1-git-send-email-k.kozlowski@samsung.com> <1417087253-12306-3-git-send-email-k.kozlowski@samsung.com> <20141127183058.GB7712@sirena.org.uk> <1417165784.18249.15.camel@AMDC1943> <20141128112116.GG7712@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xy7olSRUhBneWGFlsnLGe1WLqwyds FvOPnGO16H/8mtnibNMbdov7X48yWny70sFksenxNVaLy7vmsFnMOL+PyWLtkbvsDtweO2fd ZffYtKqTzePOtT1sHpuX1Hv0bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXxuWXa9gKPrFVTJv5 j62BcQNrFyMHh4SAicSKV1ldjJxAppjEhXvr2UBsIYGljBJz1+eB2LwCghI/Jt9jASlnFpCX OHIpGyTMLKAuMWneIuYuRi6g8s+MEju3rGaEqDeQ+L7yKSuILSwQKnHq408wm03AWGLz8iVg 80UElCWuft/LAtLMLNDMLPHvwT+wIhYBVYlfZ76CFXEKGEkcnfqVCeKgX4wSf34WQtysLNHY 7zaBUWAWkvNmIZw3C8l5CxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKExMPXHYxLj1kd YhTgYFTi4Z1gWREixJpYVlyZe4hRgoNZSYTXPR4oxJuSWFmVWpQfX1Sak1p8iJGJg1OqgTHm 6cxTderxu4wUTGdeVLiQbz3LyvFx8NFm66fvUn9YesV5VT1mDlhi9mnWWobip88STExMOBbv lHkT+nPts0d9tm2OuWp83nbnNlnfNvVdLtf8f5vWnba+D/a5zV5zfjOcnTPPRja36eIBv4uL 7XYtvht4YsYpM1+Gf+0OLf3JEVu3BlsoaiuxFGckGmoxFxUnAgAxv06QZQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2014-11-28 at 11:21 +0000, Mark Brown wrote: > On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: > > > I understand your concerns here however I didn't want to overengineer > > this. Is the same GPIO (on more complex PMICs) used in different > > contexts? Like enable control and something more in the same time? > > Yes, and it's often reprogrammable at runtime. I have doubts if generalized code could support such configuration... > > > Something like: > > struct regulator_desc desc { > > .name = "LDO1 > > .of_match = of_match_ptr("LDO1"), > > .regulators_node = of_match_ptr("voltage-regulators"), > > .ops = &max77686_ldo_ops, > > + .of_ena_gpio = of_match_ptr("ena-gpios"), > > ... > > } > > Yes, and note that this also means existing bindings can use the core > code. Thanks for idea, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property Date: Fri, 28 Nov 2014 12:54:27 +0100 Message-ID: <1417175667.18249.26.camel@AMDC1943> References: <1417087253-12306-1-git-send-email-k.kozlowski@samsung.com> <1417087253-12306-3-git-send-email-k.kozlowski@samsung.com> <20141127183058.GB7712@sirena.org.uk> <1417165784.18249.15.camel@AMDC1943> <20141128112116.GG7712@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20141128112116.GG7712-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Lee Jones , Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kukjin Kim , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org On pi=C4=85, 2014-11-28 at 11:21 +0000, Mark Brown wrote: > On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: >=20 > > I understand your concerns here however I didn't want to overengine= er > > this. Is the same GPIO (on more complex PMICs) used in different > > contexts? Like enable control and something more in the same time? >=20 > Yes, and it's often reprogrammable at runtime. I have doubts if generalized code could support such configuration... >=20 > > Something like: > > struct regulator_desc desc { > > .name =3D "LDO1 > > .of_match =3D of_match_ptr("LDO1"), > > .regulators_node =3D of_match_ptr("voltage-regulators"), > > .ops =3D &max77686_ldo_ops, > > + .of_ena_gpio =3D of_match_ptr("ena-gpios"), > > ... > > } >=20 > Yes, and note that this also means existing bindings can use the core > code. Thanks for idea, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 28 Nov 2014 12:54:27 +0100 Subject: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property In-Reply-To: <20141128112116.GG7712@sirena.org.uk> References: <1417087253-12306-1-git-send-email-k.kozlowski@samsung.com> <1417087253-12306-3-git-send-email-k.kozlowski@samsung.com> <20141127183058.GB7712@sirena.org.uk> <1417165784.18249.15.camel@AMDC1943> <20141128112116.GG7712@sirena.org.uk> Message-ID: <1417175667.18249.26.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On pi?, 2014-11-28 at 11:21 +0000, Mark Brown wrote: > On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote: > > > I understand your concerns here however I didn't want to overengineer > > this. Is the same GPIO (on more complex PMICs) used in different > > contexts? Like enable control and something more in the same time? > > Yes, and it's often reprogrammable at runtime. I have doubts if generalized code could support such configuration... > > > Something like: > > struct regulator_desc desc { > > .name = "LDO1 > > .of_match = of_match_ptr("LDO1"), > > .regulators_node = of_match_ptr("voltage-regulators"), > > .ops = &max77686_ldo_ops, > > + .of_ena_gpio = of_match_ptr("ena-gpios"), > > ... > > } > > Yes, and note that this also means existing bindings can use the core > code. Thanks for idea, Krzysztof