All of lore.kernel.org
 help / color / mirror / Atom feed
From: P J P <pjp@fedoraproject.org>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: "vv474172261@gmail.com" <vv474172261@gmail.com>,
	"mcascell@redhat.com" <mcascell@redhat.com>,
	"yuval.shaia.ml@gmail.com" <yuval.shaia.ml@gmail.com>,
	"mst@redhat.com" <mst@redhat.com>
Subject: Re: [PATCH] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)
Date: Thu, 17 Jun 2021 09:38:22 +0000 (UTC)	[thread overview]
Message-ID: <1417967078.884998.1623922702917@mail.yahoo.com> (raw)
In-Reply-To: <20210616110600.20889-1-marcel.apfelbaum@gmail.com>

On Wednesday, 16 June, 2021, 04:36:09 pm IST, Marcel Apfelbaum <marcel.apfelbaum@gmail.com> wrote:
>From: Marcel Apfelbaum <marcel@redhat.com>
>diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
>index f59879e257..dadab4966b 100644
>--- a/hw/rdma/vmw/pvrdma_cmd.c
>+++ b/hw/rdma/vmw/pvrdma_cmd.c
>@@ -38,6 +38,12 @@ static void *pvrdma_map_to_pdir(PCIDevice *pdev, uint64_t pdir_dma,
>        return NULL;
>    }
>
>+    length = ROUND_UP(length, TARGET_PAGE_SIZE);
>+    if (nchunks * TARGET_PAGE_SIZE != length) {
>+        rdma_error_report("Invalid nchunks/length (%u, %lu)", nchunks, length);
>+        return NULL;
>+    }
>+
>    dir = rdma_pci_dma_map(pdev, pdir_dma, TARGET_PAGE_SIZE);
>    if (!dir) {
>        rdma_error_report("Failed to map to page directory");
>

Looks okay.
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>


Thank you.
---
  -P J P
http://feedmug.com


  reply	other threads:[~2021-06-17 10:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 11:06 Marcel Apfelbaum
2021-06-17  9:38 ` P J P [this message]
2021-06-18  9:03 ` Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417967078.884998.1623922702917@mail.yahoo.com \
    --to=pjp@fedoraproject.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mcascell@redhat.com \
    --cc=mst@redhat.com \
    --cc=pj.pandit@yahoo.co.in \
    --cc=qemu-devel@nongnu.org \
    --cc=vv474172261@gmail.com \
    --cc=yuval.shaia.ml@gmail.com \
    --subject='Re: [PATCH] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.