All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Subject: [PATCH v2 07/10] virtio_pci: setup config vector indirectly
Date: Mon, 8 Dec 2014 17:16:50 +0200	[thread overview]
Message-ID: <1418051779-27748-8-git-send-email-mst__27008.1764589579$1418051894$gmane$org@redhat.com> (raw)
In-Reply-To: <1418051779-27748-1-git-send-email-mst@redhat.com>

config vector setup is version specific, do it indirectly.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio_pci.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 68023e5..c8ca3f7 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -89,6 +89,7 @@ struct virtio_pci_device {
 				      const char *name,
 				      u16 msix_vec);
 	void (*del_vq)(struct virtio_pci_vq_info *info);
+	u16 (*config_vector)(struct virtio_pci_device *vp_dev, u16 vector);
 };
 
 /* Constants for MSI-X */
@@ -271,6 +272,15 @@ static irqreturn_t vp_interrupt(int irq, void *opaque)
 	return vp_vring_interrupt(irq, opaque);
 }
 
+u16 vp_config_vector(struct virtio_pci_device *vp_dev, u16 vector)
+{
+	/* Setup the vector used for configuration events */
+	iowrite16(vector, vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
+	/* Verify we had enough resources to assign the vector */
+	/* Will also flush the write out to device */
+	return ioread16(vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
+}
+
 static void vp_free_vectors(struct virtio_device *vdev)
 {
 	struct virtio_pci_device *vp_dev = to_vp_device(vdev);
@@ -290,10 +300,7 @@ static void vp_free_vectors(struct virtio_device *vdev)
 
 	if (vp_dev->msix_enabled) {
 		/* Disable the vector used for configuration */
-		iowrite16(VIRTIO_MSI_NO_VECTOR,
-			  vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
-		/* Flush the write out to device */
-		ioread16(vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
+		vp_dev->config_vector(vp_dev, VIRTIO_MSI_NO_VECTOR);
 
 		pci_disable_msix(vp_dev->pci_dev);
 		vp_dev->msix_enabled = 0;
@@ -357,9 +364,8 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors,
 		goto error;
 	++vp_dev->msix_used_vectors;
 
-	iowrite16(v, vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
+	v = vp_dev->config_vector(vp_dev, v);
 	/* Verify we had enough resources to assign the vector */
-	v = ioread16(vp_dev->ioaddr + VIRTIO_MSI_CONFIG_VECTOR);
 	if (v == VIRTIO_MSI_NO_VECTOR) {
 		err = -EBUSY;
 		goto error;
@@ -770,6 +776,7 @@ static int virtio_pci_probe(struct pci_dev *pci_dev,
 	vp_dev->vdev.id.vendor = pci_dev->subsystem_vendor;
 	vp_dev->vdev.id.device = pci_dev->subsystem_device;
 
+	vp_dev->config_vector = vp_config_vector;
 	vp_dev->setup_vq = setup_vq;
 	vp_dev->del_vq = del_vq;
 
-- 
MST

  parent reply	other threads:[~2014-12-08 15:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 15:16 [PATCH v2 00/10] virtio_pci: split out legacy device support Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 01/10] virtio_pci: add isr field Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 02/10] virtio_pci: fix coding style for structs Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 03/10] virtio_pci: free up vq->priv Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 04/10] virtio_pci: use priv for vq notification Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 05/10] virtio_pci: delete vqs indirectly Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 06/10] virtio_pci: setup " Michael S. Tsirkin
2014-12-08 15:16   ` Michael S. Tsirkin
2014-12-08 15:16 ` Michael S. Tsirkin [this message]
2014-12-08 15:16 ` [PATCH v2 07/10] virtio_pci: setup config vector indirectly Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 08/10] virtio_pci: split out legacy device support Michael S. Tsirkin
2014-12-08 15:16 ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 09/10] virtio_pci: update file descriptions and copyright Michael S. Tsirkin
2014-12-08 15:16 ` Michael S. Tsirkin
2014-12-08 15:16 ` [PATCH v2 10/10] virtio_pci: rename virtio_pci -> virtio_pci_common Michael S. Tsirkin
2014-12-08 15:16 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1418051779-27748-8-git-send-email-mst__27008.1764589579$1418051894$gmane$org@redhat.com' \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.