Re: [PATCH v2] xmalloc: add support for checking the pool integrity

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2014-12-08 at 18:00 +0200, Mihai Donțu wrote:
> On Monday 08 December 2014 10:18:01 Jan Beulich wrote:
> > >>> On 08.12.14 at 03:30, <mdontu@bitdefender.com> wrote:
> > > +#ifndef NDEBUG
> > > +static bool_t xmem_pool_check_size(const struct bhdr *b, int fl, int sl)
> > > +{
> > > +    while ( b )
> > > +    {
> > > +        int __fl;
> > > +        int __sl;
> > > +
> > > +        MAPPING_INSERT(b->size, &__fl, &__sl);
> > > +        if ( __fl != fl || __sl != sl )
> > > +        {
> > > +            printk(XENLOG_ERR "xmem_pool: for block %p size = %u, { fl = %d, sl = %d } should be { fl = %d, sl = %d }\n",
> > 
> > Quoting my reply to v1: "Long line. Only the format message alone
> > is allowed to exceed 80 characters."
> > 
> 
> Just so I don't send another faulty patch, you would see that printk()
> being:
> 
>   printk(XENLOG_ERR
>          "xmem_pool: for block %p size = %u, { fl = %d, sl = %d } should be { fl = %d, sl = %d }\n",
>          b, b->size, fl, sl, __fl, __sl);
> 
> ?

The log message here is going to be substantially more than 80
characters (the format string by itself already is). Could you find a
more compact representation of the useful info?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel