All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Cc: haifeng.lin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: [PATCH RFC v2 05/12] lib/librte_vhost: host_memory_map refine
Date: Thu, 11 Dec 2014 05:37:50 +0800	[thread overview]
Message-ID: <1418247477-13920-6-git-send-email-huawei.xie@intel.com> (raw)
In-Reply-To: <1418247477-13920-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

host_memory_map only maps partial memory of target process into current process through shared backed file.

Signed-off-by: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 43 +++++++++++++--------------
 1 file changed, 20 insertions(+), 23 deletions(-)

diff --git a/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c b/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c
index fbfc403..58ac3dd 100644
--- a/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c
+++ b/lib/librte_vhost/vhost_cuse/virtio-net-cdev.c
@@ -75,8 +75,8 @@ struct procmap {
  * map it to our address space.
  */
 static int
-host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
-	pid_t pid, uint64_t addr)
+host_memory_map(pid_t pid, uint64_t addr,
+	uint64_t *mapped_address, uint64_t *mapped_size)
 {
 	struct dirent *dptr = NULL;
 	struct procmap procmap;
@@ -104,8 +104,8 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 	fmap = fopen(mapfile, "r");
 	if (fmap == NULL) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Failed to open maps file for pid %d\n",
-			dev->device_fh, pid);
+			"Failed to open maps file for pid %d\n",
+			pid);
 		return -1;
 	}
 
@@ -179,8 +179,8 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 
 	if (!found) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Failed to find memory file in pid %d maps file\n",
-			dev->device_fh, pid);
+			"Failed to find memory file in pid %d maps file\n",
+			pid);
 		return -1;
 	}
 
@@ -188,8 +188,8 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 	dp = opendir(procdir);
 	if (dp == NULL) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Cannot open pid %d process directory\n",
-			dev->device_fh, pid);
+			"Cannot open pid %d process directory\n",
+			pid);
 		return -1;
 	}
 
@@ -202,8 +202,7 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 		path = realpath(memfile, resolved_path);
 		if ((path == NULL) && (strlen(resolved_path) == 0)) {
 			RTE_LOG(ERR, VHOST_CONFIG,
-				"(%"PRIu64") Failed to resolve fd directory\n",
-				dev->device_fh);
+				"Failed to resolve fd directory\n");
 			closedir(dp);
 			return -1;
 		}
@@ -218,8 +217,8 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 
 	if (found == 0) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Failed to find memory file for pid %d\n",
-			dev->device_fh, pid);
+			"Failed to find memory file for pid %d\n",
+			pid);
 		return -1;
 	}
 	/* Open the shared memory file and map the memory into this process. */
@@ -227,32 +226,30 @@ host_memory_map(struct virtio_net *dev, struct virtio_memory *mem,
 
 	if (fd == -1) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Failed to open %s for pid %d\n",
-			dev->device_fh, memfile, pid);
+			"Failed to open %s for pid %d\n",
+			memfile, pid);
 		return -1;
 	}
 
 	map = mmap(0, (size_t)procmap.len, PROT_READ|PROT_WRITE,
-		MAP_POPULATE|MAP_SHARED, fd, 0);
+			MAP_POPULATE|MAP_SHARED, fd, 0);
 	close(fd);
 
 	if (map == MAP_FAILED) {
 		RTE_LOG(ERR, VHOST_CONFIG,
-			"(%"PRIu64") Error mapping the file %s for pid %d\n",
-			dev->device_fh, memfile, pid);
+			"Error mapping the file %s for pid %d\n",
+			memfile, pid);
 		return -1;
 	}
 
 	/* Store the memory address and size in the device data structure */
-	mem->mapped_address = (uint64_t)(uintptr_t)map;
-	mem->mapped_size = procmap.len;
+	*mapped_address = (uint64_t)(uintptr_t)map;
+	*mapped_size = procmap.len;
 
 	LOG_DEBUG(VHOST_CONFIG,
-		"(%"PRIu64") Mem File: %s->%s - Size: %llu - VA: %p\n",
-		dev->device_fh,
+		"Mem File: %s->%s - Size: %llu - VA: %p\n",
 		memfile, resolved_path,
-		(unsigned long long)mem->mapped_size, map);
+		(unsigned long long)*mapped_size, map);
 
 	return 0;
 }
-
-- 
1.8.1.4

  parent reply	other threads:[~2014-12-10 21:37 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 21:37 [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support Huawei Xie
     [not found] ` <1418247477-13920-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-10 21:37   ` [PATCH RFC v2 01/12] lib/librte_vhost: mov vhost-cuse implementation to vhost_cuse directory Huawei Xie
2014-12-10 21:37   ` [PATCH RFC v2 02/12] lib/librte_vhost: rename vhost-net-cdev.h as vhost-net.h Huawei Xie
2014-12-10 21:37   ` [PATCH RFC v2 03/12] lib/librte_vhost: move event_copy logic from virtio-net.c to vhost-net-cdev.c Huawei Xie
     [not found]     ` <1418247477-13920-4-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-07  9:10       ` Xie, Huawei
2014-12-10 21:37   ` [PATCH RFC v2 04/12] lib/librte_vhost: copy of host_memory_map from virtio-net.c to new file virtio-net-cdev.c Huawei Xie
2014-12-10 21:37   ` Huawei Xie [this message]
2014-12-10 21:37   ` [PATCH RFC v2 06/12] lib/librte_vhost: cuse_set_memory_table Huawei Xie
     [not found]     ` <1418247477-13920-7-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-15  5:20       ` Tetsuya Mukawa
2014-12-10 21:37   ` [PATCH RFC v2 07/12] lib/librte_vhost: async event and callback Huawei Xie
     [not found]     ` <1418247477-13920-8-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-15  5:20       ` Tetsuya Mukawa
     [not found]         ` <548E6F9C.1000807-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2014-12-17 17:51           ` Xie, Huawei
2014-12-10 21:37   ` [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support Huawei Xie
     [not found]     ` <1418247477-13920-9-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-11  5:36       ` Linhaifeng
     [not found]         ` <54892D4D.3060708-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-01-05 10:21           ` Xie, Huawei
2015-01-23  3:40           ` Xie, Huawei
     [not found]             ` <C37D651A908B024F974696C65296B57B0F35B8C6-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-23  3:53               ` Linhaifeng
2014-12-11  6:04       ` Linhaifeng
     [not found]         ` <548933D8.5000908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-12-11 17:13           ` Xie, Huawei
     [not found]             ` <C37D651A908B024F974696C65296B57B0F31FBD1-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-12  2:25               ` Linhaifeng
2015-01-23  3:36           ` Xie, Huawei
     [not found]             ` <C37D651A908B024F974696C65296B57B0F35B882-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-23  8:36               ` Linhaifeng
2014-12-11 20:16         ` Xie, Huawei
2014-12-16  3:05       ` Tetsuya Mukawa
     [not found]         ` <548FA172.5030604-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2014-12-17  1:06           ` Xie, Huawei
     [not found]             ` <C37D651A908B024F974696C65296B57B0F326812-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-17  3:31               ` Tetsuya Mukawa
     [not found]                 ` <5490F90E.6050701-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2014-12-17  4:22                   ` Tetsuya Mukawa
     [not found]                     ` <549104F7.20906-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2014-12-17 17:31                       ` Xie, Huawei
     [not found]                         ` <C37D651A908B024F974696C65296B57B0F3277D0-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-19  3:36                           ` Tetsuya Mukawa
2014-12-24  7:21       ` Tetsuya Mukawa
     [not found]         ` <549A6975.5060408-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2015-01-04  9:53           ` Xie, Huawei
2014-12-10 21:37   ` [PATCH RFC v2 09/12] lib/librte_vhost: minor fix Huawei Xie
2014-12-10 21:37   ` [PATCH RFC v2 10/12] lib/librte_vhost: vhost-user memory region map Huawei Xie
     [not found]     ` <1418247477-13920-11-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-16  2:38       ` Tetsuya Mukawa
2014-12-10 21:37   ` [PATCH RFC v2 11/12] lib/librte_vhost: kick/callfd fix Huawei Xie
2014-12-10 21:37   ` [PATCH RFC v2 12/12] lib/librte_vhost: cleanup when vhost user socket connection is closed Huawei Xie
2014-12-10 22:04   ` [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support Xie, Huawei
     [not found]     ` <C37D651A908B024F974696C65296B57B0F31E464-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-11  2:21       ` Tetsuya Mukawa
2014-12-15  5:26   ` Tetsuya Mukawa
     [not found]     ` <548E70F6.30807-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
2014-12-17 17:43       ` Xie, Huawei
2015-01-07 12:43         ` Qiu, Michael
2015-01-23  8:16   ` Linhaifeng
     [not found]     ` <54C20361.1090105-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-01-26  7:24       ` Xie, Huawei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418247477-13920-6-git-send-email-huawei.xie@intel.com \
    --to=huawei.xie-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=haifeng.lin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.