All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v5 7/7] gpio/xilinx: Use of_mm_gpiochip_remove
Date: Wed, 17 Dec 2014 16:51:14 +0100	[thread overview]
Message-ID: <1418831474-24428-8-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1418831474-24428-1-git-send-email-ricardo.ribalda@gmail.com>

Use the newly created of_mm_gpiochip_remove function for cleaning up
of_mm_gpiochip_add

Suggested-by: Alexandre Courbot <gnurou@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/gpio/gpio-xilinx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index e89fb42..61243d1 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -236,10 +236,7 @@ static int xgpio_remove(struct platform_device *pdev)
 {
 	struct xgpio_instance *chip = platform_get_drvdata(pdev);
 
-	gpiochip_remove(&chip->mmchip.gc);
-
-	iounmap(chip->mmchip.regs);
-	kfree(chip->mmchip.gc.label);
+	of_mm_gpiochip_remove(&chip->mmchip);
 
 	return 0;
 }
-- 
2.1.3


  parent reply	other threads:[~2014-12-17 15:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 15:51 [PATCH v5 0/7]gpio/xilinx: Add support for PCI mapped devices and rmmod Ricardo Ribalda Delgado
2014-12-17 15:51 ` [PATCH v5 1/7] gpio/xilinx: Remove offset property Ricardo Ribalda Delgado
2015-01-12  9:20   ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 2/7] gpio/xilinx: Convert the driver to platform device interface Ricardo Ribalda Delgado
2015-01-12  9:21   ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 3/7] gpio/xilinx: Add support for X86 Arch Ricardo Ribalda Delgado
2015-01-12  9:24   ` Linus Walleij
2015-01-12  9:31     ` Ricardo Ribalda Delgado
2015-01-13  9:02   ` Paul Bolle
2015-01-13  9:04     ` Ricardo Ribalda Delgado
2015-01-13  9:20       ` Paul Bolle
2015-01-15 16:13     ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 4/7] gpio/xilinx: Fix kernel-doc Ricardo Ribalda Delgado
2015-01-12  9:25   ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 5/7] gpio/xilinx: Create a single gpio chip on dual cores Ricardo Ribalda Delgado
2015-01-12  9:27   ` Linus Walleij
2014-12-17 15:51 ` [PATCH v5 6/7] gpio/gpiolib-of: Create of_mm_gpiochip_remove Ricardo Ribalda Delgado
2015-01-12  9:30   ` Linus Walleij
2015-01-12  9:31     ` Ricardo Ribalda Delgado
2015-01-12  9:33       ` Linus Walleij
2014-12-17 15:51 ` Ricardo Ribalda Delgado [this message]
2015-01-12  9:31   ` [PATCH v5 7/7] gpio/xilinx: Use of_mm_gpiochip_remove Linus Walleij
2015-01-01 15:27 ` [PATCH v5 0/7]gpio/xilinx: Add support for PCI mapped devices and rmmod Ricardo Ribalda Delgado
2015-01-12  9:32   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418831474-24428-8-git-send-email-ricardo.ribalda@gmail.com \
    --to=ricardo.ribalda@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.