From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751316AbaCWUlR (ORCPT ); Sun, 23 Mar 2014 16:41:17 -0400 Received: from moutng.kundenserver.de ([212.227.17.24]:55326 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbaCWUlP (ORCPT ); Sun, 23 Mar 2014 16:41:15 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Nicolas Pitre , Rob Herring , Rob Herring , Russell King , Catalin Marinas , x86@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH 7/8] tty/serial: add arm64 semihosting earlycon Date: Sun, 23 Mar 2014 21:23:23 +0100 Message-ID: <14193198.1gAJ7xnz7b@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1395436128-11244-1-git-send-email-robherring2@gmail.com> <1395436128-11244-8-git-send-email-robherring2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:JaZm6synsUZ/ORs3K+zhwJL9Z1fMWgFdKVOyjzklUUc jLtmvxUUEcS0BiTJjyE5M+xsBi6ZqEwU/puu1IT/9HqKZjEgmR XUOk/TYBFxpo00B3sIq1BVPsOs99A98fBKfSI3O8xN17V3/4qu NI6oThh13KarO9Letsc3jOVj1vC2VrT3utVVJ4TcfQOwAZS12F e+h/ag/hhvOEeRoFXhagxWA/YNrOatPW5BWcOtI94tliICgCC3 vy377jygBB0bDp2cSLCH2OrEqBFFECqljplTZwa7Yie42Xt7Qc K+6/xKAyEv2cZXleNu8Y6zOWvlY+WmjUzXDV/OQj4Bdg4XRkA/ Ww66EFZOMklNuwzKmnbw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 23 March 2014 16:04:41 Nicolas Pitre wrote: > On Fri, 21 Mar 2014, Rob Herring wrote: > > > From: Rob Herring > > > > Add earlycon support for the arm64 semihosting debug serial interface. > > This allows enabling a debug console when early_params are processed. > > This is based on the arm64 earlyprintk smh support and is intended to > > replace it. > > > > This is named arm rather than arm64 in hopes it will be used for both, > > but only arm64 is supported ATM. > > It can't be used for both as the semihosting calls themselves need > assembly code and this is not compatible with the equivalent ARM32 > calls. So I'd suggest naming this "arm64" to avoid potential confusion. How about using an compile-time conditional to put both inline assemblies in there? While the driver is rather trivial to start with, I don't see a point in duplicating it either. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sun, 23 Mar 2014 21:23:23 +0100 Subject: [PATCH 7/8] tty/serial: add arm64 semihosting earlycon In-Reply-To: References: <1395436128-11244-1-git-send-email-robherring2@gmail.com> <1395436128-11244-8-git-send-email-robherring2@gmail.com> Message-ID: <14193198.1gAJ7xnz7b@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sunday 23 March 2014 16:04:41 Nicolas Pitre wrote: > On Fri, 21 Mar 2014, Rob Herring wrote: > > > From: Rob Herring > > > > Add earlycon support for the arm64 semihosting debug serial interface. > > This allows enabling a debug console when early_params are processed. > > This is based on the arm64 earlyprintk smh support and is intended to > > replace it. > > > > This is named arm rather than arm64 in hopes it will be used for both, > > but only arm64 is supported ATM. > > It can't be used for both as the semihosting calls themselves need > assembly code and this is not compatible with the equivalent ARM32 > calls. So I'd suggest naming this "arm64" to avoid potential confusion. How about using an compile-time conditional to put both inline assemblies in there? While the driver is rather trivial to start with, I don't see a point in duplicating it either. Arnd