From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 6/7] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service Date: Tue, 6 Jan 2015 11:33:48 +0000 Message-ID: <1420544028.28863.144.camel@citrix.com> References: <1418988333-5404-1-git-send-email-olaf@aepfle.de> <1418988333-5404-7-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1418988333-5404-7-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, m.a.young@durham.ac.uk List-Id: xen-devel@lists.xenproject.org On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: > The references Environment file does not exist, and the service file "referenced" > does not make use of variables anyway. In principal the env vars are also for the benefit of the thing launched by the Exec line too, not just the unit file. qemu-system-i386 does use getenv() but not in any way which looks relevant under Xen (e.g. linux-user/main.c uses it, but we don't care). If someone changes exec to something (e.g. a wrapper) which cares about envvars they can equally well set EnvironmentFile too. So: Acked-by: Ian Campbell