From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005AbbAGRbe (ORCPT ); Wed, 7 Jan 2015 12:31:34 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:55359 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360AbbAGRb3 (ORCPT ); Wed, 7 Jan 2015 12:31:29 -0500 From: Suman Anna To: Grant Likely , Rob Herring CC: Greg Kroah-Hartman , Pawel Moll , Pantelis Antoniou , Felipe Balbi , , , , , Suman Anna Subject: [RFC PATCH 3/3] of/unittest: fix trailing semi-colons on conditional selftest Date: Wed, 7 Jan 2015 11:30:54 -0600 Message-ID: <1420651854-17768-4-git-send-email-s-anna@ti.com> X-Mailer: git-send-email 2.2.1 In-Reply-To: <1420651854-17768-1-git-send-email-s-anna@ti.com> References: <1420651854-17768-1-git-send-email-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_platform_populate() and of_platform_depopulate() tests are not really being tested because of some additional trailing semi-colons after the conditional checks on couple of selftest macro usage. Remove them to properly run all the platform tests. Fixes: 851da976dc1d (of/unittest: Remove test devices after adding them) Signed-off-by: Suman Anna --- drivers/of/unittest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 844838e11ef1..c67e50264e82 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -765,11 +765,11 @@ static void __init of_selftest_platform_populate(void) selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + "No testcase data in device tree\n")) return; if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + "testbus registration failed; rc=%i\n", rc)) return; for_each_child_of_node(np, child) { -- 2.2.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: [RFC PATCH 3/3] of/unittest: fix trailing semi-colons on conditional selftest Date: Wed, 7 Jan 2015 11:30:54 -0600 Message-ID: <1420651854-17768-4-git-send-email-s-anna@ti.com> References: <1420651854-17768-1-git-send-email-s-anna@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1420651854-17768-1-git-send-email-s-anna@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely , Rob Herring Cc: Greg Kroah-Hartman , Pawel Moll , Pantelis Antoniou , Felipe Balbi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Suman Anna List-Id: devicetree@vger.kernel.org The of_platform_populate() and of_platform_depopulate() tests are not really being tested because of some additional trailing semi-colons after the conditional checks on couple of selftest macro usage. Remove them to properly run all the platform tests. Fixes: 851da976dc1d (of/unittest: Remove test devices after adding them) Signed-off-by: Suman Anna --- drivers/of/unittest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 844838e11ef1..c67e50264e82 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -765,11 +765,11 @@ static void __init of_selftest_platform_populate(void) selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + "No testcase data in device tree\n")) return; if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + "testbus registration failed; rc=%i\n", rc)) return; for_each_child_of_node(np, child) { -- 2.2.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: s-anna@ti.com (Suman Anna) Date: Wed, 7 Jan 2015 11:30:54 -0600 Subject: [RFC PATCH 3/3] of/unittest: fix trailing semi-colons on conditional selftest In-Reply-To: <1420651854-17768-1-git-send-email-s-anna@ti.com> References: <1420651854-17768-1-git-send-email-s-anna@ti.com> Message-ID: <1420651854-17768-4-git-send-email-s-anna@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The of_platform_populate() and of_platform_depopulate() tests are not really being tested because of some additional trailing semi-colons after the conditional checks on couple of selftest macro usage. Remove them to properly run all the platform tests. Fixes: 851da976dc1d (of/unittest: Remove test devices after adding them) Signed-off-by: Suman Anna --- drivers/of/unittest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 844838e11ef1..c67e50264e82 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -765,11 +765,11 @@ static void __init of_selftest_platform_populate(void) selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + "No testcase data in device tree\n")) return; if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + "testbus registration failed; rc=%i\n", rc)) return; for_each_child_of_node(np, child) { -- 2.2.1