From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [libvirt test] 33157: regressions
	-	trouble:	blocked/fail/pass/preparing/queued
Date: Fri, 9 Jan 2015 09:27:45 +0000
Message-ID: <1420795665.19787.133.camel@citrix.com>
References: <osstest-33157-mainreport@xen.org> <54AEB265.9040500@suse.com>
	<1420735534.19787.114.camel@citrix.com> <54AEBB76.2060801@suse.com>
	<54AEFD29.9070506@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54AEFD29.9070506@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jim Fehlig <jfehlig@suse.com>
Cc: xen-devel@lists.xensource.com, "xen.org" <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
> Jim Fehlig wrote:
> > Ian Campbell wrote:
> >
> >   
> >> I must confess that I thought you already did use libxlu...
> >>   
> >>     
> >
> > No, not directly.  But I will be doing so now.  I should try to revert
> > all this nonsense and use libxlu before it ends up in the next libvirt
> > release.
> >   
> 
> Hmm, I don't think that is going to be possible since libxlutil.h has
> never been installed :-(.  I guess something like the below (untested)
> patch would have been necessary long ago.  Changing libvirt to use
> libxlutil would break a lot of builds where the distro's existing
> xen-devel package is missing libxlutil.h.

Whoops, yes, how embarrassing!

Acked-by: Ian Campbell <ian.campbell@citrix.com>

And of course it should be backported to everywhere.

Later:
On Thu, 2015-01-08 at 22:59 -0700, Jim Fehlig wrote:
[...]
> That's a bit pessimistic.  I could always add something like the
> following hack to libvirt

I'd say that if you combine that with an AC_CHECK_HEADERS([libxlutil.h])
in configure.ac and wrap the hack in #ifndef HAVE_LIBXLUTIL_H that
wouldn't be too aweful a hack.

> 
> typedef struct XLU_Config XLU_Config;
> 
> extern XLU_Config *xlu_cfg_init(FILE *report,
>                                 const char *report_filename);
> 
> extern int xlu_disk_parse(XLU_Config *cfg,
>                           int nspecs,
>                           const char *const *specs,
>                           libxl_device_disk *disk);
> 
> Regards,
> Jim
> 
>