From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbbALMQD (ORCPT ); Mon, 12 Jan 2015 07:16:03 -0500 Received: from cpsmtpb-ews02.kpnxchange.com ([213.75.39.5]:64379 "EHLO cpsmtpb-ews02.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbbALMQB (ORCPT ); Mon, 12 Jan 2015 07:16:01 -0500 Message-ID: <1421064958.22660.54.camel@x220> Subject: Re: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling From: Paul Bolle To: Boris Brezillon Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sergei Shtylyov , David Laight Date: Mon, 12 Jan 2015 13:15:58 +0100 In-Reply-To: <1421060278-27329-2-git-send-email-boris.brezillon@free-electrons.com> References: <1421060278-27329-1-git-send-email-boris.brezillon@free-electrons.com> <1421060278-27329-2-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 Jan 2015 12:15:58.0557 (UTC) FILETIME=[85D1D0D0:01D02E61] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote: > at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB > suspend/resume events. > > This specific handling is only activated when CONFIG_ARCH_AT91SAM9RL is > set and this option is only set when building a non-DT kernel, which is > problematic since non-DT support for at91sam9rl SoC has been removed. This sentence is not entirely correct. Commit bcf8c7e7703b ("ARM: at91: remove at91sam9rl legacy board support") actually removed the Kconfig symbol ARCH_AT91SAM9RL entirely. So the check for CONFIG_ARCH_AT91SAM9RL has been pointless since (next-20141110 and) v3.19-rc1. See my report at https://lkml.org/lkml/2014/11/10/232 . (I stumbled on this patch because I contemplated sending a patch to simply remove the check for CONFIG_ARCH_AT91SAM9RL and the currently useless function toggle_bias.) > Rework the toggle_bias implementation to attach it to the "at91sam9rl-udc" > compatible string. > > Add new compatible strings to avoid executing at91sam9rl erratum handling > on other SoCs. > > Signed-off-by: Boris Brezillon > Acked-by: Alexandre Belloni Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 From: pebolle@tiscali.nl (Paul Bolle) Date: Mon, 12 Jan 2015 13:15:58 +0100 Subject: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling In-Reply-To: <1421060278-27329-2-git-send-email-boris.brezillon@free-electrons.com> References: <1421060278-27329-1-git-send-email-boris.brezillon@free-electrons.com> <1421060278-27329-2-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <1421064958.22660.54.camel@x220> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote: > at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB > suspend/resume events. > > This specific handling is only activated when CONFIG_ARCH_AT91SAM9RL is > set and this option is only set when building a non-DT kernel, which is > problematic since non-DT support for at91sam9rl SoC has been removed. This sentence is not entirely correct. Commit bcf8c7e7703b ("ARM: at91: remove at91sam9rl legacy board support") actually removed the Kconfig symbol ARCH_AT91SAM9RL entirely. So the check for CONFIG_ARCH_AT91SAM9RL has been pointless since (next-20141110 and) v3.19-rc1. See my report at https://lkml.org/lkml/2014/11/10/232 . (I stumbled on this patch because I contemplated sending a patch to simply remove the check for CONFIG_ARCH_AT91SAM9RL and the currently useless function toggle_bias.) > Rework the toggle_bias implementation to attach it to the "at91sam9rl-udc" > compatible string. > > Add new compatible strings to avoid executing at91sam9rl erratum handling > on other SoCs. > > Signed-off-by: Boris Brezillon > Acked-by: Alexandre Belloni Paul Bolle