From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbbALNlH (ORCPT ); Mon, 12 Jan 2015 08:41:07 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:39064 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbbALNlF (ORCPT ); Mon, 12 Jan 2015 08:41:05 -0500 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Guenter Roeck , Arnd Bergmann , Greg Kroah-Hartman Cc: Steven Honeyman , Jean Delvare , Gabriele Mazzotta , Jochen Eisinger , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [PATCH 3/9] i8k: Return -ENODATA for invalid temperature Date: Mon, 12 Jan 2015 14:31:59 +0100 Message-Id: <1421069525-12875-4-git-send-email-pali.rohar@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1421069525-12875-1-git-send-email-pali.rohar@gmail.com> References: <1421069525-12875-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck suggested to return -ENODATA instead -ERANGE or -EINVAL when BIOS reports invalid temperature value. Signed-off-by: Pali Rohár Reviewed-by: Guenter Roeck Tested-by: Guenter Roeck --- drivers/char/i8k.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index afcc9fe..1854fab 100644 --- a/drivers/char/i8k.c +++ b/drivers/char/i8k.c @@ -331,7 +331,7 @@ static int i8k_get_temp(int sensor) prev[sensor] = temp; } if (temp > I8K_MAX_TEMP) - return -ERANGE; + return -ENODATA; #endif return temp; @@ -533,8 +533,6 @@ static ssize_t i8k_hwmon_show_temp(struct device *dev, int temp; temp = i8k_get_temp(index); - if (temp == -ERANGE) - return -EINVAL; if (temp < 0) return temp; return sprintf(buf, "%d\n", temp * 1000); -- 1.7.9.5