From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: [PATCH] arm64/EFI: minor corrections
Date: Mon, 12 Jan 2015 13:46:48 +0000
Message-ID: <1421070408.26317.62.camel@eu.citrix.com>
References: <54B39AED0200007800053846@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YAfKX-000879-EA
	for xen-devel@lists.xenproject.org; Mon, 12 Jan 2015 13:46:53 +0000
In-Reply-To: <54B39AED0200007800053846@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: roy.franz@linaro.org, xen-devel <xen-devel@lists.xenproject.org>, Tim Deegan <tim@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-12 at 08:59 +0000, Jan Beulich wrote:
> - don't bail when using the last slot of bootinfo.mem.bank[] (due to
>   premature incrementing of the array index)
> - GUIDs should be static const (and placed into .init.* whenever
>   possible)
> - PrintErrMsg() issues a CR/LF pair itself - no need to explicitly
>   append one to the message passed to the function
  - Avoid needless use of DisplayUint via __stringify.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Will you commit yourself or would you like me to?

Ian.