From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 00/12] Replace Xen xl parsing/formatting impl Date: Mon, 12 Jan 2015 15:06:33 +0000 Message-ID: <1421075193.26317.95.camel__3155.26369163326$1421075333$gmane$org@citrix.com> References: <1420866224-29746-1-git-send-email-jfehlig@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1420866224-29746-1-git-send-email-jfehlig@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: libvir-list@redhat.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote: > The first attempt to implement support for parsing/formatting Xen's > xl disk config format copied Xen's flex-based parser into libvirt, which > has proved to be challenging in the context of autotools. But as it turns > out, Xen provides an interface to the parser via libxlutil. > > This series reverts the first attempt, along with subsequent attempts to > fix it, and replaces it with an implementation based on libxlutil. The > first nine patches revert the original implementation and subsequent fixes. > Patch 10 provides an implemenation based on libxlutil. Patches 11 and > 12 are basically unchanged from patches 3 and 4 in the first attempt. > > One upshot of using libxlutil instead of copying the flex source is > removing the potential for source divergence. Thanks for doing this, looks good to me, FWIW. Is the presence/absence of xen-xl support exposed via virsh anywhere? If so then I can arrange for my Xen osstest patches for libvirt testing to use xen-xl when available but still fallback to xen-xm. I've had a look in "virsh capabilities" and "virsh help domxml-from-native" but not seeing xen-xm, so assuming xen-xl won't magically appear in any of those places either. (TBH, this may become moot since I suspect your patches will be well established by the time my osstest patches hit osstest...) Ian.