All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: ian.jackson@eu.citrix.com, Julien Grall <julien.grall@linaro.org>,
	wei.liu2@citrix.com, ian.campbell@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU
Date: Thu, 15 Jan 2015 21:06:18 +0000	[thread overview]
Message-ID: <1421355978-14208-3-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1421355978-14208-1-git-send-email-julien.grall@linaro.org>

QEMU upstream requires the use of pixman. When pixman is not present the
system, the configure of QEMU will fail with:

ERROR: pixman not present. Your options:
         (1) Preferred: Install the pixman devel package (any recent
             distro should have packages as Xorg needs pixman too).
         (2) Fetch the pixman submodule, using:
             git submodule update --init pixman

I think we can use by default the version on the system. So check it
a Xen configuration time to avoid a build issue later.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---
    This patch requires to regenerate tools/configure.

    Changes in v2:
        - Only check if pixman is present when building QEMU
---
 tools/configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 2aff18d..64dc75c 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -323,9 +323,10 @@ esac
  AX_CHECK_UUID
  AX_CHECK_CURSES
 
-dnl Glib 2.0 is only required when QEMU is built
+dnl Glib 2.0 and pixman are only required when QEMU is built
 AS_IF([test "x$qemu_xen" = "xy"], [
 PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12])
+PKG_CHECK_MODULES(pixman, pixman-1)
 ])
 AX_CHECK_FETCHER
 
-- 
2.1.4

  parent reply	other threads:[~2015-01-15 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 21:06 [PATCH v2 0/2] tools/configure: Add QEMU dependencies Julien Grall
2015-01-15 21:06 ` [PATCH v2 1/2] tools/configure: Check if Glib is present only when building QEMU Julien Grall
2015-01-15 21:06 ` Julien Grall [this message]
2015-01-16 10:05   ` [PATCH v2 2/2] tools/configure: Check if pixman is present on the system " Ian Campbell
2015-01-16 11:43     ` Ian Jackson
2015-01-16 12:02     ` Julien Grall
2015-01-19 17:01       ` Ian Campbell
2015-01-16 11:41 ` [PATCH v2 0/2] tools/configure: Add QEMU dependencies Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421355978-14208-3-git-send-email-julien.grall@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.