From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 2/2] tools/configure: Check if pixman is present on the system when building QEMU Date: Fri, 16 Jan 2015 10:05:53 +0000 Message-ID: <1421402753.19839.35.camel@citrix.com> References: <1421355978-14208-1-git-send-email-julien.grall@linaro.org> <1421355978-14208-3-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YC3mx-0004Yc-HE for xen-devel@lists.xenproject.org; Fri, 16 Jan 2015 10:05:59 +0000 In-Reply-To: <1421355978-14208-3-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-01-15 at 21:06 +0000, Julien Grall wrote: > QEMU upstream requires the use of pixman. When pixman is not present the > system, the configure of QEMU will fail with: > > ERROR: pixman not present. Your options: > (1) Preferred: Install the pixman devel package (any recent > distro should have packages as Xorg needs pixman too). > (2) Fetch the pixman submodule, using: > git submodule update --init pixman > > I think we can use by default the version on the system. So check it > a Xen configuration time to avoid a build issue later. > > Signed-off-by: Julien Grall > > --- > This patch requires to regenerate tools/configure. > > Changes in v2: > - Only check if pixman is present when building QEMU > --- > tools/configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/configure.ac b/tools/configure.ac > index 2aff18d..64dc75c 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -323,9 +323,10 @@ esac > AX_CHECK_UUID > AX_CHECK_CURSES > > -dnl Glib 2.0 is only required when QEMU is built > +dnl Glib 2.0 and pixman are only required when QEMU is built Rather than an ever increasing list here I propose to say "The following are only...", and perhaps insert an "upstream" before QEMU, unless these are needed for trad too (in which case the condition isn't quite right). I think glib and pixman are only for upstream though. I can do that on commit though if you like. > AS_IF([test "x$qemu_xen" = "xy"], [ > PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12]) > +PKG_CHECK_MODULES(pixman, pixman-1) > ]) > AX_CHECK_FETCHER >