All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Ian Munsie <imunsie@au1.ibm.com>
Cc: Ryan Grimm <grimm@linux.vnet.ibm.com>, mikey <mikey@neuling.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/4] CXL: Use image state defaults for reloading FPGA
Date: Mon, 19 Jan 2015 17:26:54 +1100	[thread overview]
Message-ID: <1421648814.3787.10.camel@ellerman.id.au> (raw)
In-Reply-To: <1421643145-sup-9090@delenn.ozlabs.ibm.com>

On Mon, 2015-01-19 at 16:03 +1100, Ian Munsie wrote:
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
> 
> Looks like you forgot your Signed-off-by line - mpe, do you want Ryan to
> resend the whole patch (maybe with the below explanation included), or
> just reply with a Signed-off-by?

Just resend the series please.

> This would also be good to CC: Stable, as these new defaults mean that
> the card will be fully reset when sapphire PERSTs them on reboot,
> whereas before it was left up to the default value of this register in
> each card, and could lead to a card getting into a bad state requiring a
> full power cycle to recover. The symptoms we saw was the tlbia / slbia
> we do on boot timing out and the driver init aborting.

OK.

I've decided I'm going to handle stable patches differently for the next cycle,
we've been sending too many and then sending fixups and reverts.

So please just note that you'd like it to be considered for stable, under the
--- line, and I'll add it to my list and if it's still good to go in a few
weeks then I'll send it to stable.

cheers

  reply	other threads:[~2015-01-19  6:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 19:48 [PATCH 1/4] CXL: Use image state defaults for reloading FPGA Ryan Grimm
2015-01-16 19:48 ` [PATCH 2/4] CXL: Add image control to sysfs Ryan Grimm
2015-01-19  5:05   ` Ian Munsie
2015-01-16 19:48 ` [PATCH 3/4] CXL: Enable CAPP recovery Ryan Grimm
2015-01-19  5:11   ` Ian Munsie
2015-01-16 19:48 ` [PATCH 4/4] CXL: Add ability to reset the card Ryan Grimm
2015-01-19  5:07   ` Ian Munsie
2015-01-19  5:03 ` [PATCH 1/4] CXL: Use image state defaults for reloading FPGA Ian Munsie
2015-01-19  6:26   ` Michael Ellerman [this message]
2015-01-19 17:02   ` Ryan Grimm
2015-01-19 17:52 Ryan Grimm
2015-01-20  2:10 ` Ian Munsie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421648814.3787.10.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=grimm@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.