From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: [PATCH 09/10] xen/arm: vgic-v2: Take the lock when writing into GICD_CTLR Date: Mon, 19 Jan 2015 16:29:16 +0000 Message-ID: <1421684957-29884-10-git-send-email-julien.grall@linaro.org> References: <1421684957-29884-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDFDG-0006UT-3t for xen-devel@lists.xenproject.org; Mon, 19 Jan 2015 16:30:02 +0000 Received: by mail-wg0-f45.google.com with SMTP id y19so32717137wgg.4 for ; Mon, 19 Jan 2015 08:30:00 -0800 (PST) In-Reply-To: <1421684957-29884-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org This register is shared between every vCPUs and the lock was already taken for read. Signed-off-by: Julien Grall --- This patch should be backported to Xen 4.4 and Xen 4.5. Although, it won't apply directly for Xen 4.4. --- xen/arch/arm/vgic-v2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 8c6ca72..3e5371f 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -281,7 +281,10 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_CTLR: if ( dabt.size != DABT_WORD ) goto bad_width; /* Ignore all but the enable bit */ + vgic_lock(v); v->domain->arch.vgic.ctlr = (*r) & GICD_CTL_ENABLE; + vgic_unlock(v); + return 1; /* R/O -- write ignored */ -- 2.1.4