From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 2/4] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient Date: Mon, 19 Jan 2015 17:26:08 +0000 Message-ID: <1421688368.10440.171.camel@citrix.com> References: <1420510737-22813-1-git-send-email-boris.ostrovsky@oracle.com> <1420510737-22813-3-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1420510737-22813-3-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: keir@xen.org, ufimtseva@gmail.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-05 at 21:18 -0500, Boris Ostrovsky wrote: > Instead of copying data for each field in xen_sysctl_topologyinfo separately > put cpu/socket/node into a single structure and do a single copy for each > processor. > > There is also no need to copy whole op to user at the end, max_cpu_index is > sufficient > > Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact > that these are used for CPU topology. Subsequent patch will add support for > PCI topology sysctl. > > Signed-off-by: Boris Ostrovsky > --- > tools/libxc/include/xenctrl.h | 4 +- > tools/libxc/xc_misc.c | 10 +++--- > tools/libxl/libxl.c | 52 ++++++++++----------------- > tools/misc/xenpm.c | 69 ++++++++++++++---------------------- > tools/python/xen/lowlevel/xc/xc.c | 40 +++++++-------------- FWIW the tools changes look correct to me (as expected, being largely mechanical renamings), I think there's still a decision to be made about which hypercall this is to be a sub-op of, but if the hypervisor guys agree on this approach then the tools part is: Acked-by: Ian Campbell (I'm not made keen on cputopo as an abbreviation, but not enough to ask you to type "logy" over and over ;-)) Ian.