All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: <netdev@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [RFC PATCHv1 net-next] xen-netback: always fully coalesce guest Rx packets
Date: Tue, 20 Jan 2015 11:34:06 +0000	[thread overview]
Message-ID: <1421753646.10440.228.camel@citrix.com> (raw)
In-Reply-To: <1421157917-31333-1-git-send-email-david.vrabel@citrix.com>

On Tue, 2015-01-13 at 14:05 +0000, David Vrabel wrote:
> Always fully coalesce guest Rx packets into the minimum number of ring
> slots.  Reducing the number of slots per packet has significant
> performance benefits (e.g., 7.2 Gbit/s to 11 Gbit/s in an off-host
> receive test).
> 
> However, this does increase the number of grant ops per packet which
> decreases performance with some workloads (intrahost VM to VM)
> /unless/ grant copy has been optimized for adjacent ops with the same
> source or destination (see "grant-table: defer releasing pages
> acquired in a grant copy"[1]).
> 
> Do we need to retain the existing path and make the always coalesce
> path conditional on a suitable version of Xen?
> 
> [1] http://lists.xen.org/archives/html/xen-devel/2015-01/msg01118.html
> 
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>

Looks good to me, thanks. Based on that plus the conversation in the
other subthread:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

  parent reply	other threads:[~2015-01-20 11:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 14:05 [RFC PATCHv1 net-next] xen-netback: always fully coalesce guest Rx packets David Vrabel
2015-01-13 14:30 ` Wei Liu
2015-01-19 17:36   ` David Vrabel
2015-01-19 17:36   ` [Xen-devel] " David Vrabel
2015-01-20 11:21     ` Ian Campbell
2015-01-20 11:21     ` Ian Campbell
2015-01-20 11:23     ` Ian Campbell
2015-01-20 11:23     ` [Xen-devel] " Ian Campbell
2015-01-13 14:30 ` Wei Liu
2015-01-20 11:34 ` Ian Campbell
2015-01-20 11:34 ` Ian Campbell [this message]
2015-01-20 11:38   ` David Vrabel
2015-01-20 11:38   ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2015-01-13 14:05 David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421753646.10440.228.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=netdev@vger.kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.