From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 01/10] xen/arm: vgic-v3: Correctly set
	GICD_TYPER.IDbits
Date: Tue, 20 Jan 2015 15:43:04 +0000
Message-ID: <1421768584.10440.294.camel@citrix.com>
References: <1421684957-29884-1-git-send-email-julien.grall@linaro.org>
	<1421684957-29884-2-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YDb9k-0004SC-9X
	for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 15:55:52 +0000
In-Reply-To: <1421684957-29884-2-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-19 at 16:29 +0000, Julien Grall wrote:
> +
> +        *r |= ((order - 1) << GICD_TYPE_ID_BITS_SHIFT) & GICD_TYPE_ID_BITS_MASK;

Please can you calculate the value and then construct *r in one go, so
it is easier to see all the parts in one place. Thanks.

I wonder if this field is now complex enough to warrant the union+struct
approach we use for other registers (e.g. the ESR).

Ian.