From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 07/10] xen/arm: vgic-v2: Correctly set GICD_TYPER.CPUNumber Date: Tue, 20 Jan 2015 16:06:00 +0000 Message-ID: <1421769960.10440.313.camel@citrix.com> References: <1421684957-29884-1-git-send-email-julien.grall@linaro.org> <1421684957-29884-8-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDba4-0007ap-OW for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 16:23:04 +0000 In-Reply-To: <1421684957-29884-8-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-19 at 16:29 +0000, Julien Grall wrote: > The number of implemented CPU interfaces is one more than the value of > this field. > > Also avoid to hardcode the shift and remove unuseful mask. Also avoid hardcoding... s/unuseful/useless/ > Signed-off-by: Julien Grall Acked-by: Ian Campbell