From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH] seq_file: Remove pointless assignment in seq_read() Date: Wed, 21 Jan 2015 13:46:52 +0100 Message-ID: <1421844412-15398-2-git-send-email-jack@suse.cz> References: <1421844412-15398-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Jan Kara To: Al Viro Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52356 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbbAUMrG (ORCPT ); Wed, 21 Jan 2015 07:47:06 -0500 In-Reply-To: <1421844412-15398-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The value assigned to 'err' in seq_read() is overwritten by the result of copy_to_user(). This is correct because we know we have succeeded to generate at least one entry into user buffer so the error we got when generating further entries is irrelevant. Just remove the assignment. Coverity-id: 1226981 Signed-off-by: Jan Kara --- fs/seq_file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index dbf3a59c86bb..548f78308e2a 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -255,10 +255,8 @@ Fill: size_t offs = m->count; loff_t next = pos; p = m->op->next(m, p, &next); - if (!p || IS_ERR(p)) { - err = PTR_ERR(p); + if (!p || IS_ERR(p)) break; - } err = m->op->show(m, p); if (seq_has_overflowed(m) || err) { m->count = offs; -- 2.1.2