From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934506AbdKBWEX convert rfc822-to-8bit (ORCPT ); Thu, 2 Nov 2017 18:04:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbdKBWEV (ORCPT ); Thu, 2 Nov 2017 18:04:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A10B4356D7 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1509660086.3416.15.camel@linux.vnet.ibm.com> References: <1509660086.3416.15.camel@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> To: Mimi Zohar , mcgrof@kernel.org Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Thu, 02 Nov 2017 22:04:19 +0000 Message-ID: <14219.1509660259@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 02 Nov 2017 22:04:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > > Only validly signed device firmware may be loaded. > > fw_get_filesystem_firmware() calls kernel_read_file_from_path() to > read the firmware, which calls into the security hooks. Is there > another place that validates the firmware signatures.  I'm not seeing > which patch requires firmware to be signed? Luis has a set of patches for this. However, I'm not sure if that's going anywhere at the moment. Possibly I should remove this from the manpage for the moment. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown Date: Thu, 02 Nov 2017 22:04:19 +0000 Message-ID: <14219.1509660259@warthog.procyon.org.uk> References: <1509660086.3416.15.camel@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1509660086.3416.15.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mimi Zohar , mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jforbes-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org Mimi Zohar wrote: > > Only validly signed device firmware may be loaded. > > fw_get_filesystem_firmware() calls kernel_read_file_from_path() to > read the firmware, which calls into the security hooks. Is there > another place that validates the firmware signatures.  I'm not seeing > which patch requires firmware to be signed? Luis has a set of patches for this. However, I'm not sure if that's going anywhere at the moment. Possibly I should remove this from the manpage for the moment. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: dhowells@redhat.com (David Howells) Date: Thu, 02 Nov 2017 22:04:19 +0000 Subject: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown In-Reply-To: <1509660086.3416.15.camel@linux.vnet.ibm.com> References: <1509660086.3416.15.camel@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> Message-ID: <14219.1509660259@warthog.procyon.org.uk> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Mimi Zohar wrote: > > Only validly signed device firmware may be loaded. > > fw_get_filesystem_firmware() calls kernel_read_file_from_path() to > read the firmware, which calls into the security hooks. Is there > another place that validates the firmware signatures. ?I'm not seeing > which patch requires firmware to be signed? Luis has a set of patches for this. However, I'm not sure if that's going anywhere at the moment. Possibly I should remove this from the manpage for the moment. David -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html