From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEJ39-0005nx-EB for qemu-devel@nongnu.org; Thu, 22 Jan 2015 09:48:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEJ38-00024e-HS for qemu-devel@nongnu.org; Thu, 22 Jan 2015 09:47:59 -0500 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:62748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEJ38-00023H-89 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 09:47:58 -0500 Received: by mail-wi0-f170.google.com with SMTP id em10so22115493wid.1 for ; Thu, 22 Jan 2015 06:47:57 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 22 Jan 2015 15:47:23 +0100 Message-Id: <1421938053-10318-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1421938053-10318-1-git-send-email-pbonzini@redhat.com> References: <1421938053-10318-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region_destroy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, famz@redhat.com, stefanha@redhat.com, Jan Kiszka From: Jan Kiszka Now that memory_region_destroy can be called from an RCU callback, checking the BQL-protected global memory_region_transaction_depth does not make much sense. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/memory.c b/memory.c index c343bf3..8c3d8c0 100644 --- a/memory.c +++ b/memory.c @@ -1263,7 +1263,6 @@ static void memory_region_finalize(Object *obj) MemoryRegion *mr = MEMORY_REGION(obj); assert(QTAILQ_EMPTY(&mr->subregions)); - assert(memory_region_transaction_depth == 0); mr->destructor(mr); memory_region_clear_coalescing(mr); g_free((char *)mr->name); -- 1.8.3.1