All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: linux-kernel@vger.kernel.org,
	Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: [PATCH v12 1/6] clk: Remove unneeded NULL checks
Date: Thu, 22 Jan 2015 17:13:11 +0100	[thread overview]
Message-ID: <1421943207-5180-2-git-send-email-tomeu.vizoso@collabora.com> (raw)
In-Reply-To: <1421943207-5180-1-git-send-email-tomeu.vizoso@collabora.com>

As clk_unprepare_unused_subtree and clk_disable_unused_subtree are
always called with a valid struct clk.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/clk.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index f4963b7..97f3425 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -432,9 +432,6 @@ static void clk_unprepare_unused_subtree(struct clk *clk)
 {
 	struct clk *child;
 
-	if (!clk)
-		return;
-
 	hlist_for_each_entry(child, &clk->children, child_node)
 		clk_unprepare_unused_subtree(child);
 
@@ -458,9 +455,6 @@ static void clk_disable_unused_subtree(struct clk *clk)
 	struct clk *child;
 	unsigned long flags;
 
-	if (!clk)
-		goto out;
-
 	hlist_for_each_entry(child, &clk->children, child_node)
 		clk_disable_unused_subtree(child);
 
@@ -486,9 +480,6 @@ static void clk_disable_unused_subtree(struct clk *clk)
 
 unlock_out:
 	clk_enable_unlock(flags);
-
-out:
-	return;
 }
 
 static bool clk_ignore_unused;
-- 
1.9.3


  reply	other threads:[~2015-01-22 16:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 16:13 [PATCH v12 0/6] Per-user clock constraints Tomeu Vizoso
2015-01-22 16:13 ` Tomeu Vizoso [this message]
2015-01-22 16:13 ` [PATCH v12 2/6] clk: Remove __clk_register Tomeu Vizoso
2015-01-22 19:00   ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 3/6] clk: Make clk API return per-user struct clk instances Tomeu Vizoso
2015-01-22 16:13   ` Tomeu Vizoso
2015-01-22 22:42   ` Stephen Boyd
2015-01-22 22:42     ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 4/6] clk: Add rate constraints to clocks Tomeu Vizoso
2015-01-22 16:13   ` Tomeu Vizoso
2015-01-22 22:48   ` Stephen Boyd
2015-01-22 22:48     ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 5/6] clkdev: Export clk_register_clkdev Tomeu Vizoso
2015-01-22 16:13   ` Tomeu Vizoso
2015-01-22 19:01   ` Stephen Boyd
2015-01-22 19:01     ` Stephen Boyd
2015-01-22 16:13 ` [PATCH v12 6/6] clk: Add module for unit tests Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421943207-5180-2-git-send-email-tomeu.vizoso@collabora.com \
    --to=tomeu.vizoso@collabora.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.