From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbbAWENL (ORCPT ); Thu, 22 Jan 2015 23:13:11 -0500 Received: from ozlabs.org ([103.22.144.67]:37601 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbbAWENH (ORCPT ); Thu, 22 Jan 2015 23:13:07 -0500 Message-ID: <1421986385.24984.11.camel@ellerman.id.au> Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n From: Michael Ellerman To: Pranith Kumar Cc: Stewart Smith , Rob Herring , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Mahesh Salgaonkar , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard Date: Fri, 23 Jan 2015 15:13:05 +1100 In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote: > On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith > wrote: > > Pranith Kumar writes: > >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: > >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: > >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() > >>>> return 0. Check for these return values and skip registering the dump buffer. > >>>> > >>>> Signed-off-by: Pranith Kumar > >>>> CC: Michael Ellerman > >>>> --- > >>>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ > >>>> 1 file changed, 6 insertions(+) > >>> > >>> What changed since v1? I don't see anything? > >> > >> Nothing in this patch but there is a v2 of the first patch in this > >> series, so had to resend this patch with a v2. OK. You didn't send patch 1 to the this list though, so I only saw it on lkml. Please don't do that in future. > > You also missed my Reviewed-by :) > > Sincere apologies for the oversight. Maintainers, could you please add > this Reviewed-by tag when picking this up? > > Reviewed-by: Stewart Smith For future reference patchwork will catch these tags automatically. So if you have forgotten to add them you can always reply to your own patch like you have here and patchwork will detect them. eg: http://patchwork.ozlabs.org/patch/431648/mbox/ cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id E16121A0C46 for ; Fri, 23 Jan 2015 15:13:05 +1100 (AEDT) Message-ID: <1421986385.24984.11.camel@ellerman.id.au> Subject: Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n From: Michael Ellerman To: Pranith Kumar Date: Fri, 23 Jan 2015 15:13:05 +1100 In-Reply-To: References: <1421893570-6920-1-git-send-email-bobby.prani@gmail.com> <1421893570-6920-2-git-send-email-bobby.prani@gmail.com> <1421903958.4598.4.camel@ellerman.id.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Stewart Smith , Rob Herring , Mahesh Salgaonkar , open list , Vasant Hegde , Paul Mackerras , Joel Stanley , Neelesh Gupta , "open list:LINUX FOR POWERPC..." , Anton Blanchard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote: > On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith > wrote: > > Pranith Kumar writes: > >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman wrote: > >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote: > >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get() > >>>> return 0. Check for these return values and skip registering the dump buffer. > >>>> > >>>> Signed-off-by: Pranith Kumar > >>>> CC: Michael Ellerman > >>>> --- > >>>> arch/powerpc/platforms/powernv/opal.c | 6 ++++++ > >>>> 1 file changed, 6 insertions(+) > >>> > >>> What changed since v1? I don't see anything? > >> > >> Nothing in this patch but there is a v2 of the first patch in this > >> series, so had to resend this patch with a v2. OK. You didn't send patch 1 to the this list though, so I only saw it on lkml. Please don't do that in future. > > You also missed my Reviewed-by :) > > Sincere apologies for the oversight. Maintainers, could you please add > this Reviewed-by tag when picking this up? > > Reviewed-by: Stewart Smith For future reference patchwork will catch these tags automatically. So if you have forgotten to add them you can always reply to your own patch like you have here and patchwork will detect them. eg: http://patchwork.ozlabs.org/patch/431648/mbox/ cheers