From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: wenxiong@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
Brian J King <bjking1@us.ibm.com>
Subject: Re: [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required
Date: Tue, 27 Jan 2015 05:31:56 +0100 [thread overview]
Message-ID: <1422333116.4949.100.camel@au1.ibm.com> (raw)
In-Reply-To: <54C6CF73.7000403@linux.vnet.ibm.com>
On Mon, 2015-01-26 at 17:36 -0600, Brian King wrote:
> To set some context, this function is only used by ipr for some old
> broken adapters. These are adapters that are not supported on p8,
> so will never show up under OPAL, only PowerVM. I'm fine with looking
> at alternatives for the future, but I can't say I'm too excited about
> changing the calling requirements for an API that has been around
> for many years. Particularly given that this code is only needed for
> these old adapters. If its difficult to implement this for OPAL without
> noticeable delays, could we just return -EINVAL for this function on OPAL?,
> since its not needed there today anyway.
Because it's needed for other things nowadays afaik, though IPR is the only one
that needs this to be done at interrupt time...
In fact, even with IPR and the existing call, how do you wait for the link to come
back for a PERST ? That can take a while...
Ben.
next prev parent reply other threads:[~2015-01-27 4:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 22:47 [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required Gavin Shan
2015-01-20 9:28 ` Benjamin Herrenschmidt
2015-01-20 22:56 ` Gavin Shan
2015-01-20 23:53 ` Gavin Shan
2015-01-23 3:50 ` Gavin Shan
2015-01-24 9:57 ` Benjamin Herrenschmidt
2015-01-26 23:36 ` Brian King
2015-01-27 4:31 ` Benjamin Herrenschmidt [this message]
2015-01-27 22:58 ` Brian King
2015-01-27 23:58 ` Benjamin Herrenschmidt
2015-01-30 1:37 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422333116.4949.100.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=bjking1@us.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.