From mboxrd@z Thu Jan 1 00:00:00 1970 From: BhuvanChandra.DV Subject: Re: [PATCH 3/7] spi: spi-fsl-dspi: Remove usage of devm_kzalloc Date: Wed, 28 Jan 2015 07:05:55 +0000 Message-ID: <1422429099979.36592@toradex.com> References: <1422356244-15629-1-git-send-email-bhuvanchandra.dv@toradex.com> <1422356244-15629-4-git-send-email-bhuvanchandra.dv@toradex.com> <20150127195234.GP21293@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150127195234.GP21293@sirena.org.uk> Content-Language: en-IN Content-ID: <4DFFBB99900C8C4C913A540DE3462F9E@toradex.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Brown Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux@arm.linux.org.uk" , "B44548@freescale.com" , "pawel.moll@arm.com" , "ijc+devicetree@hellion.org.uk" , "Li.Xiubo@freescale.com" , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , "linux-spi@vger.kernel.org" , "robh+dt@kernel.org" , "galak@codeaurora.org" , "shawn.guo@linaro.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 01/28/2015 01:22 AM, Mark Brown wrote: > On Tue, Jan 27, 2015 at 04:27:20PM +0530, Bhuvanchandra DV wrote: >> devm_* API was supposed to be used only in probe function call. >> Memory is allocated at 'probe' and free automatically at 'remove'. > Applied, thanks. Please don't dump entire backtraces into your commit > logs - they're far too big and not very helpful, they can obscure real > content in the message. Explain in words what the problem is and if a > backtrace helps illustrate that edit it down to only relevant portions > rather than blindly including the entire thing. OK From mboxrd@z Thu Jan 1 00:00:00 1970 From: bhuvanchandra.dv@toradex.com (BhuvanChandra.DV) Date: Wed, 28 Jan 2015 07:05:55 +0000 Subject: [PATCH 3/7] spi: spi-fsl-dspi: Remove usage of devm_kzalloc In-Reply-To: <20150127195234.GP21293@sirena.org.uk> References: <1422356244-15629-1-git-send-email-bhuvanchandra.dv@toradex.com> <1422356244-15629-4-git-send-email-bhuvanchandra.dv@toradex.com> <20150127195234.GP21293@sirena.org.uk> Message-ID: <1422429099979.36592@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/28/2015 01:22 AM, Mark Brown wrote: > On Tue, Jan 27, 2015 at 04:27:20PM +0530, Bhuvanchandra DV wrote: >> devm_* API was supposed to be used only in probe function call. >> Memory is allocated at 'probe' and free automatically at 'remove'. > Applied, thanks. Please don't dump entire backtraces into your commit > logs - they're far too big and not very helpful, they can obscure real > content in the message. Explain in words what the problem is and if a > backtrace helps illustrate that edit it down to only relevant portions > rather than blindly including the entire thing. OK