* [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning
@ 2015-01-29 12:49 Ian Jackson
2015-01-29 12:53 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2015-01-29 12:49 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Ian Campbell
$esrow is autovivified as { } by
$candrow->{EquivMostRecentStatus} = $esrow->{status}
so use %$esrow which in scalar context is true iff the
hash is nonempty.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
ts-hosts-allocate-Executive | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
index 4d5e3bb..7a9411d 100755
--- a/ts-hosts-allocate-Executive
+++ b/ts-hosts-allocate-Executive
@@ -372,7 +372,7 @@ END
$candrow->{EquivMostRecentStatus} = $esrow->{status};
print DEBUG "$dbg EQUIV-MOST-RECENT ";
print DEBUG ("$esrow->{flight}.$esrow->{job}".
- " $esrow->{val} $esrow->{status}") if $esrow;
+ " $esrow->{val} $esrow->{status}") if %$esrow;
print DEBUG ".\n";
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning
2015-01-29 12:49 [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning Ian Jackson
@ 2015-01-29 12:53 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-01-29 12:53 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Thu, 2015-01-29 at 12:49 +0000, Ian Jackson wrote:
> $esrow is autovivified as { } by
> $candrow->{EquivMostRecentStatus} = $esrow->{status}
> so use %$esrow which in scalar context is true iff the
> hash is nonempty.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I'll either push this ontop of the existing queue if that needs
restarting for some reason, or along with the libvirt stuff which we
discussed would go in next (along with your ap-push linux cleanups)
> ---
> ts-hosts-allocate-Executive | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
> index 4d5e3bb..7a9411d 100755
> --- a/ts-hosts-allocate-Executive
> +++ b/ts-hosts-allocate-Executive
> @@ -372,7 +372,7 @@ END
> $candrow->{EquivMostRecentStatus} = $esrow->{status};
> print DEBUG "$dbg EQUIV-MOST-RECENT ";
> print DEBUG ("$esrow->{flight}.$esrow->{job}".
> - " $esrow->{val} $esrow->{status}") if $esrow;
> + " $esrow->{val} $esrow->{status}") if %$esrow;
> print DEBUG ".\n";
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 12:49 [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning Ian Jackson
2015-01-29 12:53 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.