From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com, Vijaya.Kumar@caviumnetworks.com,
Julien Grall <julien.grall@linaro.org>,
tim@xen.org, ian.campbell@citrix.com
Subject: [PATCH v2 05/15] xen/arm: vgic-v3: Correctly implement read into GICR_NSACR
Date: Thu, 29 Jan 2015 18:25:40 +0000 [thread overview]
Message-ID: <1422555950-31821-6-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1422555950-31821-1-git-send-email-julien.grall@linaro.org>
The 32-bit register GICR_NSACR is RAZ/WI on non-secure state. Therefore
we should not inject a data abort to the guest.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
This patch should be backport to Xen 4.5. The current implementation will
inject a data abort into the guest.
Changes in v2:
- Patch added
---
xen/arch/arm/vgic-v3.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 1145972..2c14717 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -530,8 +530,9 @@ static int vgic_v3_rdistr_sgi_mmio_read(struct vcpu *v, mmio_info_t *info,
vgic_unlock_rank(v, rank, flags);
return 1;
case GICR_NSACR:
- if ( dabt.size != DABT_WORD ) goto bad_width;
- return 1;
+ /* We do not implement security extensions for guests, read zero */
+ goto read_as_zero_32;
+
default:
printk(XENLOG_G_ERR
"%pv: vGICR: SGI: read r%d offset %#08x\n not found",
--
2.1.4
next prev parent reply other threads:[~2015-01-29 18:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:25 [PATCH v2 00/15] xen/arm: Bug fixes for the vGIC Julien Grall
2015-01-29 18:25 ` [PATCH v2 01/15] xen/arm: vgic-v3: Correctly set GICD_TYPER.IDbits Julien Grall
2015-02-02 15:15 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 02/15] xen/arm: vgic-v3: Correctly set GICD_TYPER.CPUNumber Julien Grall
2015-01-29 18:25 ` [PATCH v2 03/15] xen/arm: vgic-v3: Correctly handle GICD_CTLR Julien Grall
2015-02-02 15:18 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 04/15] xen/arm: vgic-v3: Correctly handle RAZ/WI registers Julien Grall
2015-02-02 15:24 ` Ian Campbell
2015-02-02 15:59 ` Julien Grall
2015-02-02 16:08 ` Ian Campbell
2015-02-02 16:11 ` Julien Grall
2015-02-03 13:37 ` Julien Grall
2015-02-02 15:27 ` Ian Campbell
2015-01-29 18:25 ` Julien Grall [this message]
2015-02-02 15:35 ` [PATCH v2 05/15] xen/arm: vgic-v3: Correctly implement read into GICR_NSACR Ian Campbell
2015-01-29 18:25 ` [PATCH v2 06/15] xen/arm: vgic-v3: Set stride during domain initialization Julien Grall
2015-02-02 15:40 ` Ian Campbell
2015-02-02 16:14 ` Julien Grall
2015-01-29 18:25 ` [PATCH v2 07/15] xen/arm: vgic-v3: Use a struct to describe contiguous rdist regions Julien Grall
2015-02-02 15:47 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 08/15] xen/arm: vgic-v3: Emulate correctly the re-distributor Julien Grall
2015-02-02 15:59 ` Ian Campbell
2015-02-02 16:33 ` Julien Grall
2015-02-02 16:47 ` Ian Campbell
2015-02-02 17:05 ` Julien Grall
2015-02-02 17:38 ` Ian Campbell
2015-02-03 13:13 ` Julien Grall
2015-02-03 13:37 ` Ian Campbell
2015-02-03 6:47 ` Vijay Kilari
2015-02-03 13:09 ` Julien Grall
2015-01-29 18:25 ` [PATCH v2 09/15] xen/arm: vgic-v3: Clarify which distributor is used in the common emulation Julien Grall
2015-02-02 16:00 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 10/15] xen/arm: vgic-v2: Correctly set GICD_TYPER.CPUNumber Julien Grall
2015-01-29 18:25 ` [PATCH v2 11/15] xen/arm: vgic-v2: Correctly handle RAZ/WI registers Julien Grall
2015-02-02 16:02 ` Ian Campbell
2015-02-02 16:36 ` Julien Grall
2015-02-02 16:50 ` Ian Campbell
2015-02-02 17:08 ` Julien Grall
2015-02-02 17:41 ` Ian Campbell
2015-02-03 13:14 ` Julien Grall
2015-02-03 13:29 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 12/15] xen/arm: vgic-v2: Take the lock when writing into GICD_CTLR Julien Grall
2015-01-29 18:25 ` [PATCH v2 13/15] xen/arm: vgic-v2: GICD_I{S, C}PENDR* are only word-accessible Julien Grall
2015-02-02 16:03 ` Ian Campbell
2015-01-29 18:25 ` [PATCH v2 14/15] xen/arm: vgic: Drop iactive, ipend, pendsgi field Julien Grall
2015-02-02 16:05 ` Ian Campbell
2015-02-03 13:17 ` Julien Grall
2015-03-09 18:14 ` Stefano Stabellini
2015-01-29 18:25 ` [PATCH v2 15/15] xen/arm: gic-v3: Update some comments in the code Julien Grall
2015-02-02 16:05 ` Ian Campbell
2015-02-02 16:37 ` Julien Grall
2015-02-02 16:48 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422555950-31821-6-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.