From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758462AbbA2WKI (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Jan 2015 17:10:08 -0500
Received: from smtprelay0063.hostedemail.com ([216.40.44.63]:48603 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751265AbbA2WKH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Jan 2015 17:10:07 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:152:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2827:3138:3139:3140:3141:3142:3351:3622:3865:3868:3872:4321:5007:6261:7974:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:13894:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: offer01_3ab2e4b9fbd29
X-Filterd-Recvd-Size: 1713
Message-ID: <1422569401.16326.2.camel@perches.com>
Subject: Re: [PATCH 1/8] KVM: x86: return bool from kvm_apic_match*()
From: Joe Perches <joe@perches.com>
To: Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Nadav Amit <namit@cs.technion.ac.il>, Gleb Natapov <gleb@kernel.org>
Date: Thu, 29 Jan 2015 14:10:01 -0800
In-Reply-To: <1422568135-28402-2-git-send-email-rkrcmar@redhat.com>
References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com>
	 <1422568135-28402-2-git-send-email-rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-01-29 at 22:48 +0100, Radim Krčmář wrote:
> And don't export the internal ones while at it.
[]
> -int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
> +static bool kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>  {
>  	int result = 0;
>  	u32 logical_id;
> @@ -626,7 +626,7 @@ int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda)
>  	return result;
>  }
>  
> -int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
> +bool kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source,
>  			   int short_hand, unsigned int dest, int dest_mode)
>  {
>  	int result = 0;

Perhaps these result variables should be bool.