From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v5 0/9] XSM test case for OSSTest
Date: Tue, 3 Feb 2015 14:20:41 +0000
Message-ID: <1422973241.9323.102.camel@citrix.com>
References: <1422959786-22738-1-git-send-email-wei.liu2@citrix.com>
	<21712.53173.122503.880960@mariner.uk.xensource.com>
	<1422970905.9323.87.camel@citrix.com>
	<20150203141044.GD23306@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150203141044.GD23306@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-03 at 14:10 +0000, Wei Liu wrote:
> On Tue, Feb 03, 2015 at 01:41:45PM +0000, Ian Campbell wrote:
> > On Tue, 2015-02-03 at 13:40 +0000, Ian Jackson wrote:
> > > > Changes in v5 can be found in individual patch.
> > > > 
> > > > See below for output of
> > > >   ./standalone-generate-dump-flight-runvars > origin # master
> > > >   ./standalone-generate-dump-flight-runvars > xsm # this series applied
> > > >   diff -ub ../origin xsm  | grep '-xen-unstable' | sed  's/[ \t]*$//' # nothing
> > > >   diff -ub ../origin xsm  | grep '+xen-unstable' | sed  's/[ \t]*$//'
> > > 
> > > Can you redo this with "| sort" after
> > > ./standalone-generate-dump-flight-runvars ?  That sorts the output by
> > > job which in this case is probably easier to read.
> > 
> > Since you are regenerating can you please also add to your
> > ~/.xen-osstest/config:
> >         PlatformsArmhf midway cubietruck arndale
> > 
> > or some non-empty list at least, so we can see what will happen with
> > platforms defined.
> > 
> > (on production systems this comes from the hostdb).
> > 
> 
> [...]

> +xen-unstable               test-armhf-armhf-xl-arndale                   enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl-cubietruck                enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl                           enable_xsm                  false
> +xen-unstable               test-armhf-armhf-xl-midway                    enable_xsm                  false

I think this is from after the refactoring we talked about, and it looks
good, thanks.

Arguably it would be better if the enable_xsm was omitted for the
-platform ones, since we just want the default, but that might be a bit
icky in make-flight so I think we can live with it this way.

Ian.