From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hariprasad Shenai <hariprasad@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, leedom@chelsio.com,
anish@chelsio.com, nirranjan@chelsio.com, praveenm@chelsio.com,
kumaras@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: Add low latency socket busy_poll support
Date: Tue, 03 Feb 2015 21:58:29 -0800 [thread overview]
Message-ID: <1423029509.907.79.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1422940816-27402-1-git-send-email-hariprasad@chelsio.com>
On Tue, 2015-02-03 at 10:50 +0530, Hariprasad Shenai wrote:
> @@ -1978,9 +2016,13 @@ static int napi_rx_handler(struct napi_struct *napi, int budget)
> {
> unsigned int params;
> struct sge_rspq *q = container_of(napi, struct sge_rspq, napi);
> - int work_done = process_responses(q, budget);
> + int work_done = 0;
> u32 val;
>
> + if (!cxgb_poll_lock_napi(q))
> + return work_done;
> +
This is very suspicious. Please take a look at commits
24e579c8898aa641 ("bnx2x: fix napi poll return value for repoll")
f104fedc0da126ab ("enic: fix rx napi poll return value")
for context.
next prev parent reply other threads:[~2015-02-04 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 5:20 [PATCH net-next] cxgb4: Add low latency socket busy_poll support Hariprasad Shenai
2015-02-03 16:45 ` Rick Jones
2015-02-04 6:24 ` Kumar Sanghvi
2015-02-04 5:58 ` Eric Dumazet [this message]
2015-02-04 6:21 ` Kumar Sanghvi
2015-02-04 7:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423029509.907.79.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=praveenm@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.