From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756601AbbBEHOw (ORCPT ); Thu, 5 Feb 2015 02:14:52 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:48231 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbbBEHOv (ORCPT ); Thu, 5 Feb 2015 02:14:51 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-58-54d317d5fad0 Message-id: <1423120486.29408.2.camel@AMDC1943> Subject: Re: [v2,3/3] ARM: EXYNOS: Remove left over 'extra_save' From: Krzysztof Kozlowski To: Pankaj Dubey Cc: Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 05 Feb 2015 08:14:46 +0100 In-reply-to: <54D2F646.3090306@samsung.com> References: <1422961601-7087-3-git-send-email-k.kozlowski@samsung.com> <54D2F646.3090306@samsung.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsVy+t/xa7pXxS+HGDz+qWrR//g1s8Wmx9dY LS7vmsNmMeP8PiaL25d5LRZt/cLuwObR0tzD5rFpVSebx+Yl9R59W1YxenzeJBfAGsVlk5Ka k1mWWqRvl8CVsXelfMEuroqZ0/azNzCu5+hi5OSQEDCR2DplIjOELSZx4d56ti5GLg4hgaWM Eq2z5zBBOJ8ZJVY9vcwEUsUroC9xo/UoSxcjB4ewgIPEnq8RIGE2AWOJzcuXsIHYIgLaEp2X 77GC9DILbGaUuPD4GytIgkVAVWLm1D1gNidQ0eyze8A2CwmkS/yedJsFxGYWUJeYNG8RM8h8 CQFlicZ+N4i1ghI/Jt+DKpGX2LzmLfMERoFZSDpmISmbhaRsASPzKkbR1NLkguKk9FwjveLE 3OLSvHS95PzcTYyQoP66g3HpMatDjAIcjEo8vB29F0OEWBPLiitzDzFKcDArifBqclwOEeJN SaysSi3Kjy8qzUktPsTIxMEp1cCoYfzIN+OlFoPtnxsOWrMOVUquEO129dnx9bNbwx/1utb4 nw9myZ4x2Mcn7xdm8qXyt56mwMQVRXslda6YLHi2vPLLXvNjk/a9qddcfOyx0wVZ50etp3Sm Zhuedv9SKmqhy6C58lRz5+F6IaH5vavEm052f8uf2vnqP9urhcn3NydP/yri5G6txFKckWio xVxUnAgA6KH8QkgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On czw, 2015-02-05 at 10:19 +0530, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 03 February 2015 04:36 PM, Krzysztof Kozlowski wrote: > > Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related > > code") the Exynos 5250 no longer saves additional registers under > > 'exynos_pm_data.extra_save' field. > > > > No one else uses this code so get rid of it making also 'exynos_pm_data' > > const everywhere. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > Changes since v1: > > 1. New patch. > > --- > > arch/arm/mach-exynos/suspend.c | 13 ++----------- > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c > > index e6c961126087..d56bd6ca5e86 100644 > > --- a/arch/arm/mach-exynos/suspend.c > > +++ b/arch/arm/mach-exynos/suspend.c > > @@ -63,7 +63,6 @@ static struct sleep_save exynos_core_save[] = { > > > > struct exynos_pm_data { > > const struct exynos_wkup_irq *wkup_irq; > > - struct sleep_save *extra_save; > > int num_extra_save; > > 'num_extra_save' can be removed at the same time. > > Rest changes looks ok. Right, thanks for pointing this out. I'll resend the patchset. Best regards, Krzysztof > > Thanks, > Pankaj Dubey From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 05 Feb 2015 08:14:46 +0100 Subject: [v2,3/3] ARM: EXYNOS: Remove left over 'extra_save' In-Reply-To: <54D2F646.3090306@samsung.com> References: <1422961601-7087-3-git-send-email-k.kozlowski@samsung.com> <54D2F646.3090306@samsung.com> Message-ID: <1423120486.29408.2.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On czw, 2015-02-05 at 10:19 +0530, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 03 February 2015 04:36 PM, Krzysztof Kozlowski wrote: > > Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related > > code") the Exynos 5250 no longer saves additional registers under > > 'exynos_pm_data.extra_save' field. > > > > No one else uses this code so get rid of it making also 'exynos_pm_data' > > const everywhere. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > Changes since v1: > > 1. New patch. > > --- > > arch/arm/mach-exynos/suspend.c | 13 ++----------- > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c > > index e6c961126087..d56bd6ca5e86 100644 > > --- a/arch/arm/mach-exynos/suspend.c > > +++ b/arch/arm/mach-exynos/suspend.c > > @@ -63,7 +63,6 @@ static struct sleep_save exynos_core_save[] = { > > > > struct exynos_pm_data { > > const struct exynos_wkup_irq *wkup_irq; > > - struct sleep_save *extra_save; > > int num_extra_save; > > 'num_extra_save' can be removed at the same time. > > Rest changes looks ok. Right, thanks for pointing this out. I'll resend the patchset. Best regards, Krzysztof > > Thanks, > Pankaj Dubey