All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 09/15] i40e: stop the service task at shutdown
Date: Mon,  9 Feb 2015 02:43:55 -0800	[thread overview]
Message-ID: <1423478641-3138-10-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1423478641-3138-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Mitch Williams <mitch.a.williams@intel.com>

Stop the service task in the shutdown handler, preventing it from
accessing the admin queue after it had been closed. This fixes a panic
that could occur when the system was shut down with a lot of VFs
enabled.

Change-ID: I286735e3842de472385bbf7ad68d30331e508add
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 9efb69a..1923a0b 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -9736,6 +9736,8 @@ static int i40e_suspend(struct pci_dev *pdev, pm_message_t state)
 
 	set_bit(__I40E_SUSPENDED, &pf->state);
 	set_bit(__I40E_DOWN, &pf->state);
+	del_timer_sync(&pf->service_timer);
+	cancel_work_sync(&pf->service_task);
 	rtnl_lock();
 	i40e_prep_for_reset(pf);
 	rtnl_unlock();
-- 
1.9.3

  parent reply	other threads:[~2015-02-09 10:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 10:43 [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-02-09 Jeff Kirsher
2015-02-09 10:43 ` [net-next 01/15] i40e: i40e_fcoe.c: Remove unused function Jeff Kirsher
2015-02-09 10:43 ` [net-next 02/15] i40e: avoid use of uninitialized v_budget in i40e_init_msix Jeff Kirsher
2015-02-09 10:43 ` [net-next 03/15] i40e: delay after VF reset Jeff Kirsher
2015-02-09 10:43 ` [net-next 04/15] i40e: Use even more ARQ descriptors Jeff Kirsher
2015-02-09 10:43 ` [net-next 05/15] i40e: add locking around VF reset Jeff Kirsher
2015-02-09 10:43 ` [net-next 06/15] i40evf: reset on module unload Jeff Kirsher
2015-02-09 10:43 ` [net-next 07/15] i40evf: ignore bogus messages from FW Jeff Kirsher
2015-02-09 10:43 ` [net-next 08/15] i40evf: stop the watchdog for shutdown Jeff Kirsher
2015-02-09 10:43 ` Jeff Kirsher [this message]
2015-02-09 10:43 ` [net-next 10/15] i40evf: Force Tx writeback on ITR Jeff Kirsher
2015-02-09 10:43 ` [net-next 11/15] i40e: fix led blink toggle to enable steady state Jeff Kirsher
2015-02-09 10:43 ` [net-next 12/15] i40e: Fix function header Jeff Kirsher
2015-02-09 10:43 ` [net-next 13/15] i40e: use dev_port for fcoe netdev Jeff Kirsher
2015-02-09 10:44 ` [net-next 14/15] i40e: Enable Loopback for the FCOE vsi as well Jeff Kirsher
2015-02-09 10:44 ` [net-next 15/15] i40e/i40evf: Add call to u64_stats_init to init Jeff Kirsher
2015-02-09 12:09   ` Sergei Shtylyov
2015-02-09 16:45     ` Wyborny, Carolyn
2015-02-09 22:18 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-02-09 David Miller
2015-02-10  0:25   ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423478641-3138-10-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.