From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCHv3 6/9] openpic: fix segfault on -M mac99 savevm
Date: Mon, 9 Feb 2015 22:40:49 +0000 [thread overview]
Message-ID: <1423521652-14890-7-git-send-email-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <1423521652-14890-1-git-send-email-mark.cave-ayland@ilande.co.uk>
A simple copy/paste error causes savevm on -M mac99 to segfault.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/intc/openpic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index 7d1f3b9..8699a4a 100644
--- a/hw/intc/openpic.c
+++ b/hw/intc/openpic.c
@@ -1335,7 +1335,7 @@ static void openpic_save(QEMUFile* f, void *opaque)
for (i = 0; i < opp->max_irq; i++) {
qemu_put_be32s(f, &opp->src[i].ivpr);
qemu_put_be32s(f, &opp->src[i].idr);
- qemu_get_be32s(f, &opp->src[i].destmask);
+ qemu_put_be32s(f, &opp->src[i].destmask);
qemu_put_sbe32s(f, &opp->src[i].last_cpu);
qemu_put_sbe32s(f, &opp->src[i].pending);
}
--
1.7.10.4
next prev parent reply other threads:[~2015-02-09 22:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 22:40 [Qemu-devel] [PATCHv3 0/9] ppc: loadvm/savevm fixups for -M g3beige and -M mac99 Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 1/9] macio.c: include parent PCIDevice state in VMStateDescription Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 2/9] adb.c: include ADBDevice parent state in KBDState and MouseState Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 3/9] cuda.c: include adb_poll_timer in VMStateDescription Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 4/9] target-ppc: move sdr1 value change detection logic to helper_store_sdr1() Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 5/9] target-ppc: force update of msr bits in cpu_post_load Mark Cave-Ayland
2015-02-09 22:40 ` Mark Cave-Ayland [this message]
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 7/9] openpic: fix up loadvm under -M mac99 Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 8/9] openpic: switch IRQQueue queue from inline to bitmap Mark Cave-Ayland
2015-02-09 22:40 ` [Qemu-devel] [PATCHv3 9/9] openpic: convert to vmstate Mark Cave-Ayland
2015-02-27 13:09 ` [Qemu-devel] [Qemu-ppc] [PATCHv3 0/9] ppc: loadvm/savevm fixups for -M g3beige and -M mac99 Mark Cave-Ayland
2015-02-27 14:44 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423521652-14890-7-git-send-email-mark.cave-ayland@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.