From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Vesely Subject: Re: [libdrm][PATCH 2/2] Fix gcc -Wextra warnings Date: Mon, 09 Feb 2015 19:02:18 -0500 Message-ID: <1423526538.10898.64.camel@rutgers.edu> References: <1423517995-28251-1-git-send-email-jan.vesely@rutgers.edu> <1423517995-28251-2-git-send-email-jan.vesely@rutgers.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1214189503==" Return-path: Received: from mail-qc0-f170.google.com (mail-qc0-f170.google.com [209.85.216.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 421DE6E010 for ; Mon, 9 Feb 2015 16:02:21 -0800 (PST) Received: by mail-qc0-f170.google.com with SMTP id i8so11787754qcq.1 for ; Mon, 09 Feb 2015 16:02:20 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1214189503== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hHzlh9ofgh16wLaACX7j" --=-hHzlh9ofgh16wLaACX7j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote: > On 9 February 2015 at 21:39, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > Nice one Jan. I've sent similar fixes for drmOpenDevice and > drmGetStats a few days ago. >=20 > Considering you drop the last hunk that Ian spotted both patches are > Reviewed-by: Emil Velikov Thanks, I sent v2 of that patch few minutes ago. I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do you plan to push yours? >=20 > The strange part is that the normal Linux build does not show even a > single warning, despite the -Wextra and -Wsign-compare flags from > configure.ac. Perhaps my gcc does not like libdrm for some reason :P I think I just used CFLAGS=3D during configure, and it worked jan >=20 > -Emil --=20 Jan Vesely --=-hHzlh9ofgh16wLaACX7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJU2UqKAAoJEDhUsXb6ZiH/VmkP/1dmi20FyMehPI9tNsCVRk0U KZorcPgOPyzQ0U96CuunXLjiJOxFZWlhZ2gPCFUU70z1pW2AWjDpEIqkwe2pvsnq q96sFddobIX08tKvpC4U5MIeog4BRnk0cIlI1ZfbKvyQjIIf7cQtOyNofR8LLv9M gCxSYhdRU9RXlBcuttziaIfyRzybYs1R93hlcS29YALhNRDmMA4ArCFc3c9CJ29S SHxngCn3FpKYZeEPU1JBBtLJgKwWRBAGkv6jJ52D8rwPKLpQk7vbynS7/DN9tKuF 5/BpWOtEcx2ZEeIhn2qIHF0EKkunqwt/Tq8mQFabuN4wWJgHtUbof7EaTBNVFhbk /53+yioGNsPg2imv9jgizQG5yZkLJMAaPSO6ZxS0sstDAt6WTxDjJaP5EMuugrP3 nFxb82w2OKVsVkemu9vQmDkYQnxQrMYkcZYtUmKdcR5BijRMJWmrvBSaMYK0wuw3 3KG/tB3xQtuT/gZOlmAlxmKkeqVmVwC4oF8RLGFSH9m/PuLDWn5TGwICUN+Z6726 q4JrSM0LV2wZhglwyqDZvGT6FPQ/l9rz0ie7A9SHZRu5tYlON8UXp0uMaaZRZPld eAQMB8odEjpOm0q0y7DgBjdvYLhfk9ujJ1KH/jBlZxubnJnTMCIVqArov/X8jbmc 33pM7YPvPFgqHNIo2/ZD =F0nF -----END PGP SIGNATURE----- --=-hHzlh9ofgh16wLaACX7j-- --===============1214189503== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1214189503==--