From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hongzhou Yang Subject: Re: [PATCH v5 3/5] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135. Date: Wed, 11 Feb 2015 00:42:56 -0800 Message-ID: <1423644176.1967.12.camel@mussux00.eus.mediatek.inc> References: <1421818097-9281-1-git-send-email-hongzhou.yang@mediatek.com> <1421818097-9281-4-git-send-email-hongzhou.yang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: Mark Rutland , maoguang.meng@mediatek.com, Catalin Marinas , alan.cheng@mediatek.com, Russell King , toby.liu@mediatek.com, Grant Likely , "Joe.C" , "devicetree@vger.kernel.org" , Vladimir Murzin , Pawel Moll , Ian Campbell , Jean-Christophe PLAGNIOL-VILLARD , Rob Herring , Matthias Brugger , dandan.he@mediatek.com, huang eddie , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Ashwin Chaugule , Sascha Hauer , Kumar List-Id: devicetree@vger.kernel.org On Tue, 2015-02-10 at 16:17 +0800, Linus Walleij wrote: > On Wed, Jan 21, 2015 at 1:28 PM, Hongzhou Yang > wrote: > > > From: Hongzhou Yang > > > > The mediatek SoCs have GPIO controller that handle both the muxing and GPIOs. > > > > The GPIO controller have pinmux, pull enable, pull select, direction and output high/low control. > > > > This driver include common driver and mt8135 part. > > The common driver include the pinctrl driver and GPIO driver. > > The mt8135 part contain its special device data. > > > > Signed-off-by: Hongzhou Yang > > I have merged this patch for v3.21, except: > > > arch/arm/mach-mediatek/Kconfig | 1 + > (...) > --- a/arch/arm/mach-mediatek/Kconfig > > +++ b/arch/arm/mach-mediatek/Kconfig > > @@ -1,6 +1,7 @@ > > menuconfig ARCH_MEDIATEK > > bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7 > > select ARM_GIC > > + select PINCTRL > > select MTK_TIMER > > help > > Support for Mediatek MT65xx & MT81xx SoCs > > This, which should come in through the ARM SoC tree. It's not > dependent on this series anyway. > > This will appear after the merge window as we start the v3.21 cycle. > > Yours, > Linus Walleij Hi Linus, Due to pinconf relate API changed at kernel-3.20, a build error happened. Do I need to send patch v6? Thanks. diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 721f429..83f474b --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -391,7 +391,7 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, return -EINVAL; } - err = pinconf_generic_parse_dt_config(node, &configs, &num_configs); + err = pinconf_generic_parse_dt_config(node, pctldev, &configs, &num_configs); if (num_configs) has_config = 1; @@ -716,7 +716,7 @@ int mtk_pctrl_init(struct platform_device *pdev, prop = of_find_property(np, "pins-are-numbered", NULL); if (!prop) { - dev_err(&pdev->dev, "only support pins-are-numbered format\n", ret); + dev_err(&pdev->dev, "only support pins-are-numbered format\n"); return -EINVAL; } Yours, Hongzhou From mboxrd@z Thu Jan 1 00:00:00 1970 From: hongzhou.yang@mediatek.com (Hongzhou Yang) Date: Wed, 11 Feb 2015 00:42:56 -0800 Subject: [PATCH v5 3/5] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135. In-Reply-To: References: <1421818097-9281-1-git-send-email-hongzhou.yang@mediatek.com> <1421818097-9281-4-git-send-email-hongzhou.yang@mediatek.com> Message-ID: <1423644176.1967.12.camel@mussux00.eus.mediatek.inc> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2015-02-10 at 16:17 +0800, Linus Walleij wrote: > On Wed, Jan 21, 2015 at 1:28 PM, Hongzhou Yang > wrote: > > > From: Hongzhou Yang > > > > The mediatek SoCs have GPIO controller that handle both the muxing and GPIOs. > > > > The GPIO controller have pinmux, pull enable, pull select, direction and output high/low control. > > > > This driver include common driver and mt8135 part. > > The common driver include the pinctrl driver and GPIO driver. > > The mt8135 part contain its special device data. > > > > Signed-off-by: Hongzhou Yang > > I have merged this patch for v3.21, except: > > > arch/arm/mach-mediatek/Kconfig | 1 + > (...) > --- a/arch/arm/mach-mediatek/Kconfig > > +++ b/arch/arm/mach-mediatek/Kconfig > > @@ -1,6 +1,7 @@ > > menuconfig ARCH_MEDIATEK > > bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7 > > select ARM_GIC > > + select PINCTRL > > select MTK_TIMER > > help > > Support for Mediatek MT65xx & MT81xx SoCs > > This, which should come in through the ARM SoC tree. It's not > dependent on this series anyway. > > This will appear after the merge window as we start the v3.21 cycle. > > Yours, > Linus Walleij Hi Linus, Due to pinconf relate API changed at kernel-3.20, a build error happened. Do I need to send patch v6? Thanks. diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 721f429..83f474b --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -391,7 +391,7 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, return -EINVAL; } - err = pinconf_generic_parse_dt_config(node, &configs, &num_configs); + err = pinconf_generic_parse_dt_config(node, pctldev, &configs, &num_configs); if (num_configs) has_config = 1; @@ -716,7 +716,7 @@ int mtk_pctrl_init(struct platform_device *pdev, prop = of_find_property(np, "pins-are-numbered", NULL); if (!prop) { - dev_err(&pdev->dev, "only support pins-are-numbered format\n", ret); + dev_err(&pdev->dev, "only support pins-are-numbered format\n"); return -EINVAL; } Yours, Hongzhou