From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbbBKJkn (ORCPT ); Wed, 11 Feb 2015 04:40:43 -0500 Received: from smtprelay0242.hostedemail.com ([216.40.44.242]:53625 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751418AbbBKJkl (ORCPT ); Wed, 11 Feb 2015 04:40:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:4605:5007:6261:10004:10400:10848:11026:11232:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bell34_5cf8baed84119 X-Filterd-Recvd-Size: 2483 Message-ID: <1423647637.15343.16.camel@perches.com> Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error From: Joe Perches To: Dan Carpenter Cc: Bas Peters , Sudip Mukherjee , devel@driverdev.osuosl.org, gmate.amit@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Pushpendra Singh , manuel.schoelling@gmx.de Date: Wed, 11 Feb 2015 01:40:37 -0800 In-Reply-To: <20150211083328.GJ5206@mwanda> References: <1423573373-820-1-git-send-email-pushpendra.singh@smartplayin.com> <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com> <20150210141307.GB15593@sudip-PC> <20150211083328.GJ5206@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote: > On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel) > > >> ptr++; > > >> } > > >> } > > >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, > > >> - &pwrtrac_value); > > >> + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value); > > > you are introducing one warning to fix one error. line over 80 character. > > > > Isn't that warning more of a guideline, rather than an actual warning? Yes, it is more informational than defect. > You can't fight checkpatch.pl. Sure you can, Ignore it whenever appropriate. It's a pity there are _so_ many people that think checkpatch messages are gospel. > We reject the worst or the worst "break > lines up into smaller chunks" patches where they obviously hurt > readability, but we almost always silence the warning in the end. The > original code in this case was fine. Any line with 30+ char identifiers generally doesn't fit well in 80 char lines.