From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 2/5] i2c-designware-baytrail: fix typo in error path Date: Wed, 11 Feb 2015 18:59:51 +0200 Message-ID: <1423673991.31903.535.camel@linux.intel.com> References: <1423587970-19136-1-git-send-email-andriy.shevchenko@linux.intel.com> <1423587970-19136-2-git-send-email-andriy.shevchenko@linux.intel.com> <20150211164611.GA2712@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150211164611.GA2712@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Mika Westerberg , David Box , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jarkko Nikula List-Id: linux-i2c@vger.kernel.org On Wed, 2015-02-11 at 17:46 +0100, Wolfram Sang wrote: > > + PUNIT_SEMAPHORE, &sem); > > + if (ret) > > dev_err(dev->dev, "iosf failed to read punit semaphore\n"); > > else > > dev_err(dev->dev, "PUNIT SEM: %d\n", sem); > > Shouldn't the latter be a dev_dbg? For me it seems not. Here is error patch and we have already in error recovery, so, intention to see if the semaphore becomes alive after reset. Am I right, David? -- Andy Shevchenko Intel Finland Oy