All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Freimann <jfrei@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Thomas Huth <thuth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 14/25] s390x/mmu: Add function for accessing guest memory
Date: Thu, 12 Feb 2015 18:09:31 +0100	[thread overview]
Message-ID: <1423760982-8474-15-git-send-email-jfrei@linux.vnet.ibm.com> (raw)
In-Reply-To: <1423760982-8474-1-git-send-email-jfrei@linux.vnet.ibm.com>

From: Thomas Huth <thuth@linux.vnet.ibm.com>

According to the POP specification, the parameter blocks of various
functions like the IO instructions are accessed with logical addresses.
Thus we need a function that can read or write a buffer from/to the
guest's logical address space.

This patch now provides a function that can be used to access virtual
guest memory by using the mmu_translate function of QEMU to convert
the virtual addresses to physical.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
---
 target-s390x/cpu.h        |  11 +++++
 target-s390x/mmu_helper.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+)

diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index f8cea30..a9ab587 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -287,6 +287,7 @@ typedef struct CPUS390XState {
 #define FLAG_MASK_32            0x00001000
 
 /* Control register 0 bits */
+#define CR0_LOWPROT             0x0000000010000000ULL
 #define CR0_EDAT                0x0000000000800000ULL
 
 static inline int cpu_mmu_index (CPUS390XState *env)
@@ -897,6 +898,16 @@ int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);
 uint32_t calc_cc(CPUS390XState *env, uint32_t cc_op, uint64_t src, uint64_t dst,
                  uint64_t vr);
 
+int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, void *hostbuf, int len,
+                         bool is_write);
+
+#define s390_cpu_virt_mem_read(cpu, laddr, dest, len) \
+        s390_cpu_virt_mem_rw(cpu, laddr, dest, len, false)
+#define s390_cpu_virt_mem_write(cpu, laddr, dest, len) \
+        s390_cpu_virt_mem_rw(cpu, laddr, dest, len, true)
+#define s390_cpu_virt_mem_check_write(cpu, laddr, len) \
+        s390_cpu_virt_mem_rw(cpu, laddr, NULL, len, true)
+
 /* The value of the TOD clock for 1.1.1970. */
 #define TOD_UNIX_EPOCH 0x7d91048bca000000ULL
 
diff --git a/target-s390x/mmu_helper.c b/target-s390x/mmu_helper.c
index a1ee992..b061c85 100644
--- a/target-s390x/mmu_helper.c
+++ b/target-s390x/mmu_helper.c
@@ -15,6 +15,9 @@
  * GNU General Public License for more details.
  */
 
+#include "qemu/error-report.h"
+#include "exec/address-spaces.h"
+#include "sysemu/kvm.h"
 #include "cpu.h"
 
 /* #define DEBUG_S390 */
@@ -368,3 +371,102 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
 
     return r;
 }
+
+/**
+ * lowprot_enabled: Check whether low-address protection is enabled
+ */
+static bool lowprot_enabled(const CPUS390XState *env)
+{
+    if (!(env->cregs[0] & CR0_LOWPROT)) {
+        return false;
+    }
+    if (!(env->psw.mask & PSW_MASK_DAT)) {
+        return true;
+    }
+
+    /* Check the private-space control bit */
+    switch (env->psw.mask & PSW_MASK_ASC) {
+    case PSW_ASC_PRIMARY:
+        return !(env->cregs[1] & _ASCE_PRIVATE_SPACE);
+    case PSW_ASC_SECONDARY:
+        return !(env->cregs[7] & _ASCE_PRIVATE_SPACE);
+    case PSW_ASC_HOME:
+        return !(env->cregs[13] & _ASCE_PRIVATE_SPACE);
+    default:
+        /* We don't support access register mode */
+        error_report("unsupported addressing mode");
+        exit(1);
+    }
+}
+
+/**
+ * translate_pages: Translate a set of consecutive logical page addresses
+ * to absolute addresses
+ */
+static int translate_pages(S390CPU *cpu, vaddr addr, int nr_pages,
+                           target_ulong *pages, bool is_write)
+{
+    bool lowprot = is_write && lowprot_enabled(&cpu->env);
+    uint64_t asc = cpu->env.psw.mask & PSW_MASK_ASC;
+    CPUS390XState *env = &cpu->env;
+    int ret, i, pflags;
+
+    for (i = 0; i < nr_pages; i++) {
+        /* Low-address protection? */
+        if (lowprot && (addr < 512 || (addr >= 4096 && addr < 4096 + 512))) {
+            trigger_access_exception(env, PGM_PROTECTION, ILEN_LATER_INC, 0);
+            return -EACCES;
+        }
+        ret = mmu_translate(env, addr, is_write, asc, &pages[i], &pflags, true);
+        if (ret) {
+            return ret;
+        }
+        if (!address_space_access_valid(&address_space_memory, pages[i],
+                                        TARGET_PAGE_SIZE, is_write)) {
+            program_interrupt(env, PGM_ADDRESSING, 0);
+            return -EFAULT;
+        }
+        addr += TARGET_PAGE_SIZE;
+    }
+
+    return 0;
+}
+
+/**
+ * s390_cpu_virt_mem_rw:
+ * @laddr:     the logical start address
+ * @hostbuf:   buffer in host memory. NULL = do only checks w/o copying
+ * @len:       length that should be transfered
+ * @is_write:  true = write, false = read
+ * Returns:    0 on success, non-zero if an exception occured
+ *
+ * Copy from/to guest memory using logical addresses. Note that we inject a
+ * program interrupt in case there is an error while accessing the memory.
+ */
+int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, void *hostbuf,
+                         int len, bool is_write)
+{
+    int currlen, nr_pages, i;
+    target_ulong *pages;
+    int ret;
+
+    nr_pages = (((laddr & ~TARGET_PAGE_MASK) + len - 1) >> TARGET_PAGE_BITS)
+               + 1;
+    pages = g_malloc(nr_pages * sizeof(*pages));
+
+    ret = translate_pages(cpu, laddr, nr_pages, pages, is_write);
+    if (ret == 0 && hostbuf != NULL) {
+        /* Copy data by stepping through the area page by page */
+        for (i = 0; i < nr_pages; i++) {
+            currlen = MIN(len, TARGET_PAGE_SIZE - (laddr % TARGET_PAGE_SIZE));
+            cpu_physical_memory_rw(pages[i] | (laddr & ~TARGET_PAGE_MASK),
+                                   hostbuf, currlen, is_write);
+            laddr += currlen;
+            hostbuf += currlen;
+            len -= currlen;
+        }
+    }
+
+    g_free(pages);
+    return ret;
+}
-- 
2.1.4

  parent reply	other threads:[~2015-02-12 17:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 17:09 [Qemu-devel] [PATCH 00/25] s390x: rework guest memory access Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 01/25] s390x/mmu: Move mmu_translate() and friends to separate file Jens Freimann
2015-02-17 12:35   ` Alexander Graf
2015-02-12 17:09 ` [Qemu-devel] [PATCH 02/25] s390x/mmu: Fix the check for the real-space designation bit Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 03/25] s390x/mmu: Fix the handling of the table levels Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 04/25] s390x/mmu: Check table length and offset fields Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 05/25] s390x/mmu: Skip exceptions properly when translating addresses for debug Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 06/25] s390x/mmu: Fix translation exception code in lowcore Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 07/25] s390x/mmu: Fix exception types when checking the ASCEs Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 08/25] s390x/mmu: Fix the exception codes for illegal table entries Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 09/25] s390x/mmu: Add support for read-only regions Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 10/25] s390x/mmu: Renaming related to the ASCE confusion Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 11/25] s390x/mmu: Check bit 52 in page table entry Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 12/25] s390x/mmu: Clean up mmu_translate_asc() Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 13/25] s390x/kvm: Add function for injecting pgm access exceptions Jens Freimann
2015-02-12 17:09 ` Jens Freimann [this message]
2015-02-12 17:09 ` [Qemu-devel] [PATCH 15/25] s390x/css: Make schib parameter of css_do_msch const Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 16/25] s390x/ioinst: Rework memory access in MSCH instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 17/25] s390x/ioinst: Rework memory access in SSCH instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 18/25] s390x/ioinst: Rework memory access in STSCH instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 19/25] s390x/ioinst: Set condition code in ioinst_handle_tsch() handler Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 20/25] s390x/ioinst: Rework memory access in TSCH instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 21/25] s390x/ioinst: Rework memory access in STCRW instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 22/25] s390x/ioinst: Rework memory access in CHSC instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 23/25] s390x/ioinst: Rework memory access in TPI instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 24/25] s390x/pci: Rework memory access in zpci instruction Jens Freimann
2015-02-12 17:09 ` [Qemu-devel] [PATCH 25/25] s390x/helper: Remove s390_cpu_physical_memory_map Jens Freimann
2015-02-18  8:40 ` [Qemu-devel] [PATCH 00/25] s390x: rework guest memory access Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423760982-8474-15-git-send-email-jfrei@linux.vnet.ibm.com \
    --to=jfrei@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.