All of lore.kernel.org
 help / color / mirror / Atom feed
From: alison@she-devel.com (alison at she-devel.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6: WEIM: put node reference on early loop exit
Date: Fri, 13 Feb 2015 09:33:04 -0800	[thread overview]
Message-ID: <1423848784-6988-1-git-send-email-alison_chaiken@mentor.com> (raw)

From: Alison Chaiken <alison_chaiken@mentor.com>

Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com>
---
 drivers/bus/imx-weim.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 0958b69..11f2c8b 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -158,7 +158,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
 		if (ret) {
 			dev_err(&pdev->dev, "%s set timing failed.\n",
 				child->full_name);
-			return ret;
+			goto put_node;
 		}
 	}
 
@@ -166,7 +166,14 @@ static int __init weim_parse_dt(struct platform_device *pdev,
 				   of_default_bus_match_table,
 				   NULL, &pdev->dev);
 	if (ret)
-		dev_err(&pdev->dev, "%s fail to create devices.\n",
+		goto out;
+
+	return 0;
+
+put_node:
+	of_node_put(child);
+out:
+	dev_err(&pdev->dev, "%s fail to create devices.\n",
 			pdev->dev.of_node->full_name);
 	return ret;
 }
-- 
2.1.4

             reply	other threads:[~2015-02-13 17:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 17:33 alison at she-devel.com [this message]
2015-02-16  5:47 ` [PATCH] i.MX6: WEIM: put node reference on early loop exit Sascha Hauer
2015-02-17 16:28   ` Chaiken, Alison
2015-02-17 17:51     ` Joshua Clayton
2015-02-18  8:37       ` [PATCH] i.MX6: WEIM: improve error handling upon child probe-failure alison at she-devel.com
2015-02-18 16:30         ` Joshua Clayton
2015-02-19  7:19       ` [PATCH v3 0/1] " alison at she-devel.com
2015-02-19  7:24       ` [PATCH v3 1/1] " alison at she-devel.com
2015-02-23  7:17         ` Sascha Hauer
2015-03-02 13:51         ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423848784-6988-1-git-send-email-alison_chaiken@mentor.com \
    --to=alison@she-devel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.