From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v5 07/24] libxl: add vmemrange to libxl__domain_build_state Date: Mon, 16 Feb 2015 16:00:19 +0000 Message-ID: <1424102416.2591.16.camel@citrix.com> References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com> <1423770294-9779-8-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8102888630991563430==" Return-path: In-Reply-To: <1423770294-9779-8-git-send-email-wei.liu2@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: "JBeulich@suse.com" , Andrew Cooper , "xen-devel@lists.xen.org" , "ufimtseva@gmail.com" , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============8102888630991563430== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-0QN7uXHsQ40pZ4fLKCWn" --=-0QN7uXHsQ40pZ4fLKCWn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote: > A vnode consists of one or more vmemranges (virtual memory range). One > example of multiple vmemranges is that there is a hole in one vnode. >=20 > Currently we haven't exported vmemrange interface to libxl user. > Vmemranges are generated during domain build, so we have relevant > structures in domain build state. >=20 > Later if we discover we need to export the interface, those structures > can be moved to libxl_domain_build_info as well. >=20 > These new fields (along with other fields in that struct) are set to 0 > at start of day so we don't need to explicitly initialise them. A > following patch which introduces an independent checking function will > need to access these fields. I don't feel very comfortable squashing > this change into that one so I didn't use a single commit. >=20 > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Dario Faggioli > Cc: Elena Ufimtseva > Acked-by: Ian Campbell > Reviewed-by: Dario Faggioli > --- > Changes in v5: > 1. Fix commit message. >=20 > Changes in v4: > 1. Improve commit message. >=20 > Changes in v3: > 1. Rewrite commit message. > This is a rather amusing changes history, allow me to say! :-D :-D Regards, Dario PS. The patch (as well as others) has Ian's ack already, so I know my rev-by tag is rather pointless. However, as I've been involved in the process, I'd still like to point out I've looked at and am ok with this. Feel free not to incorporate the tag if you don't want to, or if you're not resending some of the patches. --=-0QN7uXHsQ40pZ4fLKCWn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlTiFBAACgkQk4XaBE3IOsTwwACfQVCbdKhm43C4NpcZyn1POaT7 U6YAni0xF+TZi3u30Ssx4C20Lgl+up+Y =ObZz -----END PGP SIGNATURE----- --=-0QN7uXHsQ40pZ4fLKCWn-- --===============8102888630991563430== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8102888630991563430==--