From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 17/24] libxl: build,
 check and pass vNUMA info to Xen for HVM guest
Date: Tue, 17 Feb 2015 14:26:23 +0000
Message-ID: <1424183181.4235.69.camel@citrix.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-18-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7151409493441038043=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423770294-9779-18-git-send-email-wei.liu2@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "JBeulich@suse.com" <JBeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "ufimtseva@gmail.com" <ufimtseva@gmail.com>, Ian Jackson <Ian.Jackson@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============7151409493441038043==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-xAi4Nw7R+AGO1DFAaKEN"

--=-xAi4Nw7R+AGO1DFAaKEN
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:

> --- a/tools/libxc/xc_hvm_build_x86.c
> +++ b/tools/libxc/xc_hvm_build_x86.c
> @@ -407,7 +407,7 @@ static int setup_guest(xc_interface *xch,
>              new_memflags |=3D XENMEMF_exact_node_request;
>          }
> =20
> -        end_pages =3D args->vmemranges[i].end >> PAGE_SHIFT;
> +        end_pages =3D args->vmemranges[vmemid].end >> PAGE_SHIFT;
>
What's this? I suspect this should be using vmemid already in patch 16,
shouldn't it?

Other than this,

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario

--=-xAi4Nw7R+AGO1DFAaKEN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTjT40ACgkQk4XaBE3IOsS7LgCfdGougatT5C1fA8onckhxpZna
UiYAn2sFGv/7N3DH+3r5x3oAiAQUxiDH
=cvpx
-----END PGP SIGNATURE-----

--=-xAi4Nw7R+AGO1DFAaKEN--


--===============7151409493441038043==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7151409493441038043==--