From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 10/24] libxl: functions to build
 vmemranges for PV guest
Date: Tue, 17 Feb 2015 15:28:15 +0000
Message-ID: <1424186893.4235.78.camel@citrix.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-11-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9090972324829468552=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423770294-9779-11-git-send-email-wei.liu2@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "JBeulich@suse.com" <JBeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "ufimtseva@gmail.com" <ufimtseva@gmail.com>, Ian Jackson <Ian.Jackson@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============9090972324829468552==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-xxLvyxamF0nz+Q5SVNMN"

--=-xxLvyxamF0nz+Q5SVNMN
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:

> --- a/tools/libxl/libxl_x86.c
> +++ b/tools/libxl/libxl_x86.c
> @@ -339,6 +339,79 @@ int libxl__arch_domain_finalise_hw_description(libxl=
__gc *gc,
>      return 0;
>  }
> =20
> +/* Return 0 on success, ERROR_* on failure. */
> +int libxl__arch_vnuma_build_vmemrange(libxl__gc *gc,
> +                                      uint32_t domid,
> +                                      libxl_domain_build_info *b_info,
> +                                      libxl__domain_build_state *state)
>
The doc comment does not look super useful as it is... ERRROR_* is
ERROR_NOMEM, right?

Perhaps say that, along with a few words on when it happens (or just get
rid of the comment entiretly)

In any case,

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Dario

--=-xxLvyxamF0nz+Q5SVNMN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTjXg0ACgkQk4XaBE3IOsRg2ACff8ei+2QZekw8AJbtv9wRx1So
FmcAoIa13c34fMfw661PZmfZ0DXGkWg8
=JnSS
-----END PGP SIGNATURE-----

--=-xxLvyxamF0nz+Q5SVNMN--


--===============9090972324829468552==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============9090972324829468552==--