From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 08/24] libxl: introduce
	libxl__vnuma_config_check
Date: Tue, 17 Feb 2015 16:51:03 +0000
Message-ID: <1424191861.4235.98.camel@citrix.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-9-git-send-email-wei.liu2@citrix.com>
	<21726.1811.311219.353545@mariner.uk.xensource.com>
	<20150213151251.GE13644@zion.uk.xensource.com>
	<CAEr7rXivACY4fJc_KzCsaPRNQbyR9aTsE8ZJWWysqZXcfhUPGQ@mail.gmail.com>
	<20150213160635.GJ13644@zion.uk.xensource.com>
	<CAEr7rXiqFXFOe-oytpsHkcv-yccj-yD8ZcyOm5Duj7kBFiqLkg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4491980059878877596=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAEr7rXiqFXFOe-oytpsHkcv-yccj-yD8ZcyOm5Duj7kBFiqLkg@mail.gmail.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "ufimtseva@gmail.com" <ufimtseva@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "JBeulich@suse.com" <JBeulich@suse.com>, Ian Jackson <Ian.Jackson@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============4491980059878877596==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-1ZA148MxINY8kqIdePTh"

--=-1ZA148MxINY8kqIdePTh
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-02-13 at 11:11 -0500, Elena Ufimtseva wrote:
> On Fri, Feb 13, 2015 at 11:06 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Fri, Feb 13, 2015 at 10:39:25AM -0500, Elena Ufimtseva wrote:

> >> Any sanity checks for distances?
> >>
> >
> > The same applies, what is a valid distance what is not? I guess zero is
> > not valid? Or do we enforce that the distance to local node must be
> > smaller than or equal to the distance to remote node?
>=20
> Yes, I think the second condition is enough for strict checking.
>=20
That would not harm, probably but I honestly would not put down much
enforcement on distance values. We can enforce non-zero values, we can
enforce local < remote, we can enforce the symmetry of the distance
matrix, but, really, I wouldn't go that far.

What matters most wrt specification of the distances, is to provide a
sane default, in case one does not want to bother writing it down (or
does not want to write it down completely, as it could be tedious).

So, if one does not say anything, we should come up with something that
makes sense (and I'll say more about this while reviewing patch 24). If
the user does say something, I would just go with that... perhaps after
printing a warning, but no more than that.

Regards,
Dario

--=-1ZA148MxINY8kqIdePTh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTjcXUACgkQk4XaBE3IOsTHNgCfW07JrQUGoeul3i8Enie46evX
VzYAnRHmhVDCGJ0BLunZkZRrqAhazkSg
=7OWV
-----END PGP SIGNATURE-----

--=-1ZA148MxINY8kqIdePTh--


--===============4491980059878877596==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4491980059878877596==--