From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties Date: Wed, 18 Feb 2015 15:44:05 +0000 Message-ID: <1424274245.20761.20.camel@citrix.com> References: <1414144694.15687.31.camel@citrix.com> <1414144717-32328-5-git-send-email-ian.campbell@citrix.com> <54E37B62.4020101@linaro.org> <1424267412.27775.62.camel@citrix.com> <54E49F55.2010402@linaro.org> <1424270232.27775.83.camel@citrix.com> <54E4AA4E.3080501@linaro.org> <1424272693.20761.13.camel@citrix.com> <54E4B037.2000308@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54E4B037.2000308@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xen.org, Clark Laughlin , tim@xen.org, stefano.stabellini@eu.citrix.com, Pranavkumar Sawargaonkar List-Id: xen-devel@lists.xenproject.org On Wed, 2015-02-18 at 15:31 +0000, Julien Grall wrote: > > Either soc has a device_type property which we understand, in which case > > we would handle it and stop recursing or (more likely for an soc) it > > does not, in which case we would handle the pcie ranges property, but it > > needs to be translated through the ranges property of soc, which the > > patch doesn't do and probably it should. > > The code to do it is quite complicate and hard to maintain (actually > it's a copy of the Linux one). It would be good if you can re-use the > functions to translate in common/device_tree.c. Of course. > I think we may have the same problem for interrupts too. Yes. In that case ISTR the existing functions needed an SBDF, so weren't quite right for the "up front mapping" approach -- but that can surely be fixed via some refactoring. Ian.