From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 05/24] xen/arm: vgic: Introduce a function to initialize pending_irq Date: Fri, 20 Feb 2015 15:24:16 +0000 Message-ID: <1424445856.30924.299.camel@citrix.com> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-6-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOpor-0000xc-OA for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 15:48:45 +0000 In-Reply-To: <1421159133-31526-6-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote: > The structure pending_irq is initialized on the same way in 2 differents "in the same way in 2 different places". > place. Introduce vgic_init_pending_irq to avoid code duplication. > > Also move the setting of the irq field in this function as we need to "...into this function..." > initialize it once rather than every time an IRQ is injected to the guest. > > Finally, use unsigned int for the "irq" field to be consistent with the > virq variable > > Signed-off-by: Julien Grall > Acked-by: Stefano Stabellini Acked-by: Ian Campbell